Skip to content

DPE-7649 Replace event.set_results(success=False) with event.fail() in action get-cluster-status #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astrojuanlu merged 2 commits into from
Oct 27, 2025
Merged

DPE-7649 Replace event.set_results(success=False) with event.fail() in action get-cluster-status #673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fff78da
fix: use event.fail() instead of set_results(success=False)
astrojuanlu Oct 27, 2025
02d8fb7
test: remove unwanted tests
astrojuanlu Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions lib/charms/mysql/v0/mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,23 +597,26 @@ def _on_set_password(self, event: ActionEvent) -> None:

def _get_cluster_status(self, event: ActionEvent) -> None:
"""Action used to retrieve the cluster status."""
if event.params.get("cluster-set"):
logger.debug("Getting cluster set status")
status = self._mysql.get_cluster_set_status(extended=0)
else:
logger.debug("Getting cluster status")
status = self._mysql.get_cluster_status()
try:
if event.params.get("cluster-set"):
logger.debug("Getting cluster set status")
status = self._mysql.get_cluster_set_status(extended=0)
else:
logger.debug("Getting cluster status")
status = self._mysql.get_cluster_status()

if not status:
event.fail("Failed to read cluster status. See logs for more information.")
return

if status:
event.set_results({
"success": True,
"status": status,
})
else:
event.set_results({
"success": False,
"message": "Failed to read cluster status. See logs for more information.",
})

except Exception:
logger.exception("Error while reading cluster status")
event.fail("Error while reading cluster status. See logs for more information.")

def _on_promote_to_primary(self, event: ActionEvent) -> None:
"""Action for setting this unit as the cluster primary."""
Expand Down
Loading