Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64 issues #2473

Merged
merged 9 commits into from
Sep 24, 2024
Merged

AArch64 issues #2473

merged 9 commits into from
Sep 24, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Sep 7, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Based on: #2469

@Rot127
Fix, shift immediate was casted to incorrect width.
7e3c3ca
@Rot127
Store theexact float also in fp field for convenience.
49866da
@Rot127
Fix: MRS has no implicit write of NCVZ
b0a155d
@Rot127
Fix signs of Imm8 shifted operands.
576499e
@Rot127
Fix another MRS test
7d5e5aa
@Rot127
Fix: Src operand of CASAL had write flag set.

Detailed description

Fixes several AArch64 issues reported by @FinnWilkinson

Test plan

Added

Closing issues

closes #2471

Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, merged

@kabeor kabeor merged commit 823bfd5 into capstone-engine:next Sep 24, 2024
19 checks passed
@Rot127 Rot127 deleted the AArch64-issues branch September 24, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AArch64] Max operand count is too low
2 participants