Skip to content

Fix(multi select) change for navigating multi select item in multi select web component #21013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gururajj77 merged 4 commits into from
Dec 8, 2025
Merged

Fix(multi select) change for navigating multi select item in multi select web component #21013

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02a7353
fix(multi-select): change for multi-select-item navigation
Divyue30597 Nov 12, 2025
5ef9224
fix(multi-select): updates the logic for keyboard navigation
Divyue30597 Nov 13, 2025
909a313
Merge branch 'main' into fix(multi-select)--change-for-navigating-mul…
Gururajj77 Nov 18, 2025
5abb9f1
Merge branch 'main' into fix(multi-select)--change-for-navigating-mul…
heloiselui Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 5 additions & 32 deletions packages/web-components/src/components/multi-select/multi-select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@ import { property, query } from 'lit/decorators.js';
import { classMap } from 'lit/directives/class-map.js';
import { prefix } from '../../globals/settings';
import Close16 from '@carbon/icons/es/close/16.js';
import {
filter,
forEach,
indexOf,
} from '../../globals/internal/collection-helpers';
import { filter, forEach } from '../../globals/internal/collection-helpers';
import CDSDropdown, {
DROPDOWN_KEYBOARD_ACTION,
DROPDOWN_TYPE,
Expand Down Expand Up @@ -534,34 +530,11 @@ class CDSMultiSelect extends CDSDropdown {
* @param direction `-1` to navigate backward, `1` to navigate forward.
*/
protected _navigate(direction: number) {
if (!this.filterable) {
super._navigate(direction);
this._triggerNode.classList.add('no-focus-style');
} else {
// only navigate through remaining item
const constructor = this.constructor as typeof CDSMultiSelect;
const items = this.querySelectorAll(constructor.selectorItemResults);
const highlightedItem = this.querySelector(
constructor.selectorItemHighlighted
);
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- https://github.com/carbon-design-system/carbon/issues/20452
const highlightedIndex = indexOf(items, highlightedItem!);

let nextIndex = highlightedIndex + direction;

if (items[nextIndex]?.hasAttribute('disabled')) {
nextIndex += direction;
}
if (nextIndex < 0) {
nextIndex = items.length - 1;
}
if (nextIndex >= items.length) {
nextIndex = 0;
}
forEach(items, (item, i) => {
(item as CDSMultiSelectItem).highlighted = i === nextIndex;
});
super._navigate(direction);
if (this.filterable) {
this.setAttribute('item-clicked', '');
} else {
this._triggerNode.classList.add('no-focus-style');
}
}

Expand Down
Loading