Properly identify and check Scala.js dependencies#100
Open
keynmol wants to merge 3 commits intocb372:mainfrom
Open
Properly identify and check Scala.js dependencies#100keynmol wants to merge 3 commits intocb372:mainfrom
keynmol wants to merge 3 commits intocb372:mainfrom
Conversation
This was referenced Jan 22, 2022
Contributor
Author
|
@cb372 👋 this PR is 2 years old so I don't quite remember what I was doing - but if you are interested in this functionality, I'll be available to address feedback! |
Owner
|
So you noticed that this plugin has risen from the dead! Thank you for this PR, which I totally missed the first time around. A couple of quick comments before I review properly:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
It felt like almost luck to discover that sbt-platform-deps puts stuff into the
Binary:D@cb372 I'm putting this PR up in relatively incomplete state for the following reasons:
But more importantly: to make sure you agree with the approach.
I would like to do the same changes for Scala Native dependencies, but given the relative usage stats it can be a separate PR/release.