Repository navigation
Review pull requests with a model, and say why a feature belongs - #120
Merged
Merged
Conversation
Every pull request is read against .github/agent/review-prompt.md and answered in one comment with one ai: label: accepted, changes-requested, out-of-scope or needs-review. The comment is edited in place when the branch moves, so a pull request carries one review rather than one per push. The judgement is this repository's, not a copy of the widget library's. Three differences matter: - versions and changelogs are cut at release here (9.0.28 is the shape of one, and the monthly metadata workflow bumps its own), so the reviewer does not ask a contributor for either — it flags a diff that moves the version on its own, because publishing is a human's decision; - lib/src/metadata/generated/** is produced by resources/generate_files.dart, so editing it without touching resources/ is blocking, mechanically, whatever the model answers; - this package is pure Dart on purpose, so a pubspec.yaml that gains a Flutter dependency is blocking for the same reason: the widget library depends on this one, not the other way round. A feature has to argue for itself: the answer carries a case naming the problem it solves, the method it does not duplicate or the issue it answers, and triage.py will not let an acceptance stand without one. The reviewer is given the README's feature list and the exported surface to judge that against, because a diff can show what a change adds and never what was already there. Merging is off until AUTO_MERGE says otherwise, and refuses to arm on a branch with no required checks: an automerger that merges before CI is worse than none.
cedvdb
force-pushed
the
feat/ai-reviewer
branch
from
November 10, 2026 15:13
3e29c6a to
ac8fb21
Compare
4 tasks done
cedvdb
added a commit
that referenced
this pull request
Nov 10, 2026
Create Tag from pubspec.yaml failed on the push that merged #120: ❌ Tag v9.0.29 already exists on remote. Failing workflow. That is not a change going wrong. v9.0.29 was tagged when #119 merged, #120 changed nothing that ships, and the workflow treats "already released" as an error. So every merge that does not bump the version leaves a red run on main, and a red X that fires on ordinary merges stops being read. An already-tagged version is now a notice and a skip. The changelog guard is unchanged and still runs, but only when there is a tag to create, so a version bump without a `## x.y.z` heading still fails — which is the check this workflow exists for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
A reviewer for every pull request, the same machine as
phone_form_fieldruns: read against.github/agent/review-prompt.md, answered in one comment with oneai:label, edited in placewhen the branch moves.
.github/agent/review-prompt.md.github/agent/triage.py--self-testruns offline.github/agent/collect.py.github/workflows/review.yml.github/agent/README.mdIt is this repository's rules, not a copy
The widget library asks contributors to bump
pubspec.yamland add aCHANGELOG.mdheading. Thisrepository does not:
9.0.28is a single release commit, and the monthly metadata workflow bumps itsown version. So asking a contributor for a version bump here would be noise, and the mechanical checks
are different:
phone_form_fieldlib/src/localization/generated/**needs the.arblib/src/metadata/generated/**needsresources/Those two are enforced in
triage.py, not asked for in the prompt, so no reading of a diff candisagree: a hand-edited generated map, or a
pubspec.yamlthat gains Flutter, comes out asai:changes-requestedwhatever the model answered.A feature has to earn its place
A fix is judged on whether it is correct. A feature is judged on whether it should exist: whose
problem it solves, whether anyone asked for it, and whether its cost is proportionate. When it accepts
one, the reviewer must write the argument, and the comment carries it as Why it belongs here. An
acceptance with no argument is not an acceptance —
triage.pyturns it intoai:needs-review,because that part is a person's to decide.
To judge "this already exists" as a fact rather than a guess,
collect.pyputs the README's featurelist and the exported surface in front of the model, read from the base branch.
Turning it on
One secret is the whole feature; without it the job runs, logs a notice and does nothing.
gh secret set GEMINI_API_KEY --repo cedvdb/phone_numbers_parserMerging stays off (
AUTO_MERGEunset) — the bot labels and comments only..github/agent/README.mddocuments the switches and why it refuses to arm a merge on a branch with no required checks.
Checks
triage.py --self-test— 52 cases, offlinerun:blocks passbash -ncollect.pyon this checkout finds the Features list and the sevenexportlinesoverruled to
changes-requestednaming the rule, and a parser fix with its test is acceptedNo dependency changes, no version bump, and nothing in
lib/is touched — this pull request adds areviewer and nothing else.