-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(ci): Fix unit flakes from testnode by stopping calling the stop functions multiple times
#4663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't think I'm missing other failures, but this one is still present. afaiu this is not testnode related. |
|
FYI, we agreed internally to skip the retriever tests and have yet to make the change. These are old reconstruction tests, and this code is not used, so feel free to ignore it. As to why it's failing after being stable for a long time, I believe the flakes are coming from IPFS-related dependencies, since that is the only thing that changed in this code. |
renaynay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @evan-forbes
Ran this locally and didn't hit any flakes. CI looks like only failing on retriever tests which are not resp of core-app 👍🏻
testnode by stopping calling the stop functions multiple times
|
Thank you! |
53992af to
6151289
Compare
trying a hack in CI