Skip to content

Conversation

@evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Oct 27, 2025

trying a hack in CI

@evan-forbes evan-forbes self-assigned this Oct 27, 2025
@evan-forbes evan-forbes added the kind:ci CI related PRs label Oct 27, 2025
@github-actions github-actions bot added the external Issues created by non node team members label Oct 27, 2025
@evan-forbes
Copy link
Member Author

I don't think I'm missing other failures, but this one is still present. afaiu this is not testnode related.

--- FAIL: TestRetriever_Retrieve (465.29s)
    --- FAIL: TestRetriever_Retrieve/128x128(max) (464.22s)
        retriever_test.go:61: 
            	Error Trace:	/Users/runner/work/celestia-node/celestia-node/share/eds/retriever_test.go:61
            	Error:      	Received unexpected error:
            	            	context deadline exceeded
            	Test:       	TestRetriever_Retrieve/128x128(max)
--- FAIL: TestFraudProofValidation (20.22s)
    --- FAIL: TestFraudProofValidation/ods_size:128 (8.39s)
        retriever_test.go:127: 
            	Error Trace:	/Users/runner/work/celestia-node/celestia-node/share/eds/retriever_test.go:127
            	            				/Users/runner/work/celestia-node/celestia-node/share/eds/retriever_test.go:108
            	Error:      	Received unexpected error:
            	            	before batch commit: context deadline exceeded
            	Test:       	TestFraudProofValidation/ods_size:128
FAIL
coverage: 75.3% of statements
FAIL	github.com/celestiaorg/celestia-node/share/eds	524.601s

@evan-forbes evan-forbes marked this pull request as ready for review October 27, 2025 18:31
@Wondertan
Copy link
Member

Wondertan commented Oct 27, 2025

FYI, we agreed internally to skip the retriever tests and have yet to make the change. These are old reconstruction tests, and this code is not used, so feel free to ignore it. As to why it's failing after being stable for a long time, I believe the flakes are coming from IPFS-related dependencies, since that is the only thing that changed in this code.

renaynay
renaynay previously approved these changes Oct 28, 2025
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @evan-forbes

Ran this locally and didn't hit any flakes. CI looks like only failing on retriever tests which are not resp of core-app 👍🏻

@renaynay renaynay changed the title fix: stop calling the stop functions multiple times fix(ci): Fix unit flakes from testnode by stopping calling the stop functions multiple times Oct 28, 2025
walldiss
walldiss previously approved these changes Oct 28, 2025
@walldiss
Copy link
Member

Thank you!

@walldiss walldiss enabled auto-merge October 28, 2025 14:14
@renaynay renaynay dismissed stale reviews from walldiss and themself via 6151289 November 7, 2025 19:15
@walldiss walldiss disabled auto-merge November 7, 2025 19:45
@walldiss walldiss enabled auto-merge November 7, 2025 19:45
@walldiss walldiss added this pull request to the merge queue Nov 7, 2025
Merged via the queue into main with commit 2186fce Nov 7, 2025
31 of 33 checks passed
@walldiss walldiss deleted the evan/ci/try-fix branch November 7, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external Issues created by non node team members kind:ci CI related PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants