Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving ROM 1.x to a new 1.0 folder #1625

Closed
wants to merge 1 commit into from
Closed

Moving ROM 1.x to a new 1.0 folder #1625

wants to merge 1 commit into from

Conversation

mhatrevi
Copy link
Collaborator

No description provided.

@korran
Copy link
Collaborator

korran commented Jul 30, 2024

Do we really need to keep the 1.x ROM source around in the main tree? We've already got binaries for regression-testing purposes:

https://github.com/chipsalliance/caliptra-sw/blob/main/hw/1.0/caliptra-rom-1.0.1-9342687.bin

Copy link
Collaborator

@jhand2 jhand2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this folder be named 1.x? I want to avoid confusion since the current rom in this directory is 1.1.

@korran
Copy link
Collaborator

korran commented Jul 30, 2024

Do we really need to keep the 1.x ROM source around in the main tree? We've already got binaries for regression-testing purposes:

https://github.com/chipsalliance/caliptra-sw/blob/main/hw/1.0/caliptra-rom-1.0.1-9342687.bin

I guess if we're planning to simultaneously work on a 1.2 ROM along with a very-different 2.0 ROM, maybe it makes sense to have a directory for each. But if 1.2 is runtime-fw-only, I think we can just delete the 1.x ROM source (or evolve it into 2.x).

@mhatrevi
Copy link
Collaborator Author

mhatrevi commented Nov 2, 2024

This change is no longer needed.

@mhatrevi mhatrevi closed this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants