Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide API to use absolute path for SourceInfo #4316

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sequencer
Copy link
Member

@sequencer sequencer commented Jul 27, 2024

In our build flow, we split the fir elaboration phase and firtool phase into different sandboxes to enable build cache and reproducibility. which means they are not able to observe each other unless using an absolute path. Thus I'm adding a new API to use absolute path to chisel SourceInfo. When defining the -Dchisel.project.root.absolute, all source info will be absolute, so that there won't this issue anymore.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • API modification
  • API deprecation
  • Backend code generation
  • Performance improvement
  • Bugfix
  • Documentation or website-related
  • Dependency update
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).
  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

- bug fix that chisel.project.root doesn't take effect
- if CHISEL_PROJECT_ROOT_ABSOLUTE is defined, use absolute path in
  chisel SourceInfo
- if CHISEL_PROJECT_ROOT_REPLACE is defined, replace CHISEL_PROJECT_ROOT
  or user.dir with it in chisel chisel SourceInfo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant