Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cross-compiling FIRRTL source files with Scala3 #4403

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

adkian-sifive
Copy link
Contributor

@adkian-sifive adkian-sifive commented Sep 16, 2024

Part of the larger work of preparing for Scala3 support

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Refactor FIRRTL sources to support cross-compilation with Scala3

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Copy link

linux-foundation-easycla bot commented Sep 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@jackkoenig
Copy link
Contributor

I'm happy with this as is, but I think we should also add -Xsource:3 to the scalacOptions for firrtl so that we can enforce we don't regress on some of these changes. Do you want to do that here or in the next PR?

@adkian-sifive
Copy link
Contributor Author

I like the idea of adding -Xsource:3 on a subproject basis

@adkian-sifive adkian-sifive force-pushed the adkian-sifive/firrtl-cross-compile branch from feebafb to 764619f Compare September 20, 2024 14:53
@adkian-sifive adkian-sifive force-pushed the adkian-sifive/firrtl-cross-compile branch from 764619f to 6c07211 Compare September 20, 2024 15:10
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM but see suggestion

@adkian-sifive adkian-sifive merged commit b5cf7b0 into main Sep 30, 2024
15 checks passed
@adkian-sifive adkian-sifive deleted the adkian-sifive/firrtl-cross-compile branch September 30, 2024 18:19
debs-sifive pushed a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants