-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cross-compiling FIRRTL source files with Scala3 #4403
Conversation
ac775c8
to
2948b62
Compare
I'm happy with this as is, but I think we should also add |
I like the idea of adding -Xsource:3 on a subproject basis |
feebafb
to
764619f
Compare
764619f
to
6c07211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM but see suggestion
Co-authored-by: Jack Koenig <[email protected]>
Part of the larger work of preparing for Scala3 support
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Refactor FIRRTL sources to support cross-compilation with Scala3
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.