Update github-integration.adoc #9209
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeFunes
commented
Feb 7, 2025
| @@ -323,7 +323,7 @@ Key functionality enabled through the GitHub App integration includes the follow | |||
| * A **more flexible trigger system**, with each pipeline having any number of VCS or non-VCS triggers. This includes: | |||
| ** **Non-repo based triggers**: xref:webhooks#custom-webhooks[Custom webhooks] enable triggering builds from any system that can emit webhook events. Refer to our link:https://discuss.circleci.com/t/product-update-trigger-pipelines-from-anywhere-custom-webhooks/49864[community forum] for an example and known limitations. | |||
| ** **Cross-repo triggers**: Events in one repository can trigger builds on one or many other repositories. | |||
| ** [Coming soon] **More GitHub events as triggers**: Pipelines can be set up to run on events other than "push", with more powerful customization of trigger conditions. | |||
| ** **More GitHub events as triggers**: Pipelines can be set up to run on events other than "push", including pull request events, with more powerful customization of trigger conditions. | |||
There was a problem hiding this comment.
Could we add a link from "more github events as triggers" to https://circleci.com/docs/github-app-trigger-options/ ?
| @@ -323,7 +323,7 @@ Key functionality enabled through the GitHub App integration includes the follow | |||
| * A **more flexible trigger system**, with each pipeline having any number of VCS or non-VCS triggers. This includes: | |||
| ** **Non-repo based triggers**: xref:webhooks#custom-webhooks[Custom webhooks] enable triggering builds from any system that can emit webhook events. Refer to our link:https://discuss.circleci.com/t/product-update-trigger-pipelines-from-anywhere-custom-webhooks/49864[community forum] for an example and known limitations. | |||
| ** **Cross-repo triggers**: Events in one repository can trigger builds on one or many other repositories. | |||
| ** [Coming soon] **More GitHub events as triggers**: Pipelines can be set up to run on events other than "push", with more powerful customization of trigger conditions. | |||
| ** **More GitHub events as triggers**: Pipelines can be set up to run on events other than "push", including pull request events, with more powerful customization of trigger conditions. | |||
There was a problem hiding this comment.
Suggested change
| ** **More GitHub events as triggers**: Pipelines can be set up to run on events other than "push", including pull request events, with more powerful customization of trigger conditions. | |
| ** **More GitHub events as triggers**: Pipelines can be set up to run on events other than "push", including pull request events, with more powerful customization of trigger conditions. For full details, see the xref:github-event-trigger-options#[GitHub event trigger options] page. |
There was a problem hiding this comment.
Can do this? This will work once the name change PR is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A brief description of the changes.
Reasons
A link to a GitHub and/or JIRA issue (if applicable).
Otherwise, a brief sentence about why you made these changes.
Content Checklist
Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.
Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 😸: