Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github-integration.adoc #9209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jekyll/_cci2/github-integration.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ Key functionality enabled through the GitHub App integration includes the follow
* A **more flexible trigger system**, with each pipeline having any number of VCS or non-VCS triggers. This includes:
** **Non-repo based triggers**: xref:webhooks#custom-webhooks[Custom webhooks] enable triggering builds from any system that can emit webhook events. Refer to our link:https://discuss.circleci.com/t/product-update-trigger-pipelines-from-anywhere-custom-webhooks/49864[community forum] for an example and known limitations.
** **Cross-repo triggers**: Events in one repository can trigger builds on one or many other repositories.
** [Coming soon] **More GitHub events as triggers**: Pipelines can be set up to run on events other than "push", with more powerful customization of trigger conditions.
** **More GitHub events as triggers**: Pipelines can be set up to run on events other than "push", including pull request events, with more powerful customization of trigger conditions.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a link from "more github events as triggers" to https://circleci.com/docs/github-app-trigger-options/ ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** **More GitHub events as triggers**: Pipelines can be set up to run on events other than "push", including pull request events, with more powerful customization of trigger conditions.
** **More GitHub events as triggers**: Pipelines can be set up to run on events other than "push", including pull request events, with more powerful customization of trigger conditions. For full details, see the xref:github-event-trigger-options#[GitHub event trigger options] page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do this? This will work once the name change PR is merged


[#installing-github-app-alongside-github-oauth-app]
### Installing GitHub App alongside the GitHub OAuth app
Expand Down