Generate peplink launches #275
Conversation
…er + base station hardware. Move the wireless_watcher flag into platform.wireless
civerachb-cpr
requested review from
tonybaltovski and
roni-kreinin
and removed request for
a team
🧪 CI InsightsHere's what we observed from your CI run for 517591e. 🟢 All jobs passed!But CI Insights is watching 👀 |
| package='peplink_router_driver', | ||
| executable='peplink_router_node', | ||
| name='router_node', | ||
| namespace=f'{self.namespace}/network/router', |
There was a problem hiding this comment.
Should we namespace this under wireless/router instead to keep naming consistent? Wireless watcher should probably be under the same namespace too
There was a problem hiding this comment.
I was hesitant to change the wireless watcher namespace since that's already been published in our platform API and we may have users (e.g. outdoornav) already relying on that topic as-is.
As for network/router and network/base_station vs wireless/router and wireless/base_station I have no strong opinions either way. I chose network since it's broader in case we ever expand to non-wireless networking equipment. But that may be unnecessary future-proofing.
There was a problem hiding this comment.
That is true, some of our MCUs look at the platform/wifi_connected topic to control the HMI wifi LED. I think one of the issues we have seen though is that when the robot is not using onboard wifi, the LED will be off even though it is connected through a peplink. It would be nice to have a single topic indicating wifi connection status regardless of source.
There was a problem hiding this comment.
I think for now that's probably out-of-scope for this MR. Definitely a good future feature to include though.
civerachb-cpr
requested review from
roni-kreinin
and removed request for
tonybaltovski
Use the new
platform.wirelesssection for wireless watcher, peplink router generation.Currently only peplink devices are supported, but the code is designed to be expandable in the future.
See:
platform.wirelesssection to config clearpath_config#201