Add client-info to clone op

[ericdallo]

As discussed on this thread, we want to have client information about the nrepl client, we discussed about adding this extra info in clone op as optional information.

Related to nrepl/nrepl#370

---

Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• All tests are passing (eldev test)
• All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • byte-compilation, checkdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.

[ericdallo]

@bbatsov I think the tests failing are not related to this PR

[alexander-yakushev]

Looks like it is related to the PR:

[ericdallo]

That's weird, the PR just add optional data, any clues @alexander-yakushev ?

[alexander-yakushev]

Yeah, it is weird. This works correctly locally. @bbatsov any ideas?

[bbatsov]

There's a mocked nREPL server for the integration tests that you'll probably have to update. Guess something's off with it's implementation.

[bbatsov]

See https://github.com/clojure-emacs/cider/blob/master/test/nrepl-server-mock.el

[alexander-yakushev]

Looks like the mock expects the clone message to be exactly this, without the extra fields: https://github.com/clojure-emacs/cider/blob/master/test/nrepl-server-mock.el#L46

[ericdallo]

makes sense, just wondering how to get civer-version on that file

[ericdallo]

I think I got it :)

[alexander-yakushev]

LGTM!