Skip to content

Add client-info to clone op #3806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
- [#3797](https://github.com/clojure-emacs/cider/issues/3797): Completion: enable `cider-completion-style` by default (this enables richer completion suggestions where candidates don't have to strictly match the prefix).
- [#3803](https://github.com/clojure-emacs/cider/pull/3803): Enable dynamic indentation for `clojure-ts-mode`.
- [#3805](https://github.com/clojure-emacs/cider/pull/3805): Profiler: update to latest profiling middleware.
- [#3806](https://github.com/clojure-emacs/cider/pull/3806): Add client info to `clone` op request.

### Bugs fixed

Expand Down
6 changes: 5 additions & 1 deletion nrepl-client.el
Original file line number Diff line number Diff line change
Expand Up @@ -1032,12 +1032,16 @@ ADDITIONAL-PARAMS is a plist to be appended to the request message."
connection
tooling))

(defvar cider-version)

(defun nrepl-sync-request:clone (connection &optional tooling)
"Sent a :clone request to create a new client session.
The request is dispatched via CONNECTION.
Optional argument TOOLING Tooling is set to t if wanting the tooling session
from CONNECTION."
(nrepl-send-sync-request '("op" "clone")
(nrepl-send-sync-request `("op" "clone"
"client-name" "CIDER"
"client-version" ,cider-version)
connection
nil tooling))

Expand Down
5 changes: 4 additions & 1 deletion test/nrepl-server-mock.el
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ requirements."
(let* ((msg (queue-dequeue (cdr (nrepl-bdecode output))))
(_ (mock/log! ":mock.filter/msg :in %S" msg))
(response (pcase msg
(`(dict "op" "clone" "id" ,id)
(`(dict "op" "clone"
"client-name" "CIDER"
"client-version" ,cider-version
"id" ,id)
`(dict "id" ,id
"session" "a-session"
"status" ("done")
Expand Down