Disable vhost selection on vhost specific views #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasSarlin
force-pushed
the
disable-vhost-selection-on-vhost-locked-views
branch
from
54e8f5d to
caddc88
Compare
ThomasSarlin
force-pushed
the
disable-vhost-selection-on-vhost-locked-views
branch
from
edf3ac1 to
4ea4092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Close #1287
A different approach which adds a helper that disables the vhost selection for specific views.
The initial thought was as follows:
#1566 (comment)
But as
layout.jsis loaded before the different view specific Javascript files, the approach with setting a value towindow.vhostLockedfalls short on execution. Another alternative is to call a function (Helper.disableUserMenuVhost) that disables the vhost-selector on view load in each specific view, presented in this PR.HOW can this pull request be tested?
Try clicking the vhost-swap selector in a vhost-locked view, should not work ✅
Try clicking the vhost-swap selector in a non-vhost-locked view, should work ✅