Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Supernova): Delete all unnecessary parsers in Zustand. #778

Open
4 tasks
Tracked by #762
TilmanHaupt opened this issue Feb 13, 2025 · 1 comment
Open
4 tasks
Tracked by #762

(Supernova): Delete all unnecessary parsers in Zustand. #778

TilmanHaupt opened this issue Feb 13, 2025 · 1 comment
Assignees
Labels
refactor supernova All tasks related to supernova

Comments

@TilmanHaupt
Copy link
Contributor

TilmanHaupt commented Feb 13, 2025

Review the Zustand store and identify functions that perform unnecessary type checking due to TypeScript's built-in type safety. Remove redundant type-checking functions and any associated logic that is no longer needed to streamline the code. Ensure the refactored code remains functional and maintainable.

  • delete all unnecessary parseX functions
  • delete all unnecessary validateX functions
  • check all anys if they can be deleted
  • ensure all slices are typed with interfaces
@edda
Copy link
Contributor

edda commented Feb 21, 2025

Please keep in mind that most of the content of the store is data that was fetched via API. So in many cases we'll probably need to keep the validators and checkers because there is no TypeScript type safety at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor supernova All tasks related to supernova
Projects
None yet
Development

No branches or pull requests

2 participants