-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removes dependencies on React <19 in test utils #3252
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3252 +/- ##
========================================
Coverage 96.42% 96.42%
========================================
Files 791 791
Lines 22603 22606 +3
Branches 7396 7745 +349
========================================
+ Hits 21795 21798 +3
+ Misses 801 754 -47
- Partials 7 54 +47 ☔ View full report in Codecov by Sentry. |
7e789e9
to
d311907
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the same license thing from the test utils should apply here too? Will wait for that here as well (unless we don't need it here for some reason, and I don't have to).
No, I will remove the attributed code from this repo and import it from the test-utils instead. |
d311907
to
a566435
Compare
a566435
to
8b361da
Compare
Description
The PR updates the uses of Simulate test-util from React with a custom event dispatcher.
Depends on: #3252
Rel: AWSUI-60345
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.