Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes dependencies on React <19 in test utils #3252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Feb 5, 2025

Description

The PR updates the uses of Simulate test-util from React with a custom event dispatcher.

Depends on: #3252

Rel: AWSUI-60345

How has this been tested?

  • Existing unit tests pass with minor adjustments (calling change when the value remains the same now has no effect)
  • Dry-run
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (20e6a83) to head (8b361da).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3252    +/-   ##
========================================
  Coverage   96.42%   96.42%            
========================================
  Files         791      791            
  Lines       22603    22606     +3     
  Branches     7396     7745   +349     
========================================
+ Hits        21795    21798     +3     
+ Misses        801      754    -47     
- Partials        7       54    +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@avinashbot avinashbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the same license thing from the test utils should apply here too? Will wait for that here as well (unless we don't need it here for some reason, and I don't have to).

@pan-kot
Copy link
Member Author

pan-kot commented Feb 19, 2025

I guess the same license thing from the test utils should apply here too? Will wait for that here as well (unless we don't need it here for some reason, and I don't have to).

No, I will remove the attributed code from this repo and import it from the test-utils instead.

@pan-kot pan-kot force-pushed the chore-react19-compat branch from d311907 to a566435 Compare February 21, 2025 09:13
@pan-kot pan-kot force-pushed the chore-react19-compat branch from a566435 to 8b361da Compare February 21, 2025 09:14
@pan-kot pan-kot marked this pull request as ready for review February 21, 2025 09:15
@pan-kot pan-kot requested a review from a team as a code owner February 21, 2025 09:15
@pan-kot pan-kot requested review from gethinwebster and avinashbot and removed request for a team February 21, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants