-
Notifications
You must be signed in to change notification settings - Fork 4k
release-25.2: roachtest: randomize volume type and XFS #160033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-25.2
Are you sure you want to change the base?
Conversation
Prior to this patch, tests had three possiblities for volume types: 1. Specify `PreferLocalSSD()` `DisableLocalSSD()` options. 2. Force a specific volume type via `VolumeType()` (volume type being provider specific, this was only possible for tests that target a single provider). 3. Rely on the default behavior for `PreferLocalSSD()` and use the default volume type in roachprod for the provider in case local SSD was not selected. The way `PreferLocalSSD()` was implemented meant that most of the tests were actually running on local SSDs (when available on the machine type), leading to a gap in the testing strategy with regards to volume types. This patch brings the new ClusterSpec option `RandomizeVolumeType()`. In case volume type is not forced and neither `PreferLocalSSD()` or `DisableLocalSSD()` are specified, specifying `RandomizeVolumeType()` will take precendence over the `--local-ssd` argument and will randomly select a volume type from those available in the targeted provider: - AWS: gp3, io2, local SSD - GCE: pd-ssd, local SSD - Azure: premium-ssd, premium-ssd-v2, ultra-disk, local SSD - IBM: 10iops-tier Note: volume type randomization gives the same weight to all options. This patch also introduces a random chance of provisioning XFS as a filesystem via the option `RandomlyUseXfs()`. The option is built in the same way as `RandomlyUseZfs()`, granting a 20% chance of XFS if present. If both `RandomlyUseZfs()` and `RandomlyUseXfs()` are used, they both get a 20% chance, leaving 60% chance for the default ext4. Epic: none Fixes: 146661 Release note: None
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
|
✅ PR #160033 is compliant with backport policy Confidence: high 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Backport 1/1 commits from #159010.
/cc @cockroachdb/release
Prior to this patch, tests had three possiblities for volume types:
PreferLocalSSD()DisableLocalSSD()options.VolumeType()(volume type being provider specific, this was only possible for tests that target a single provider).PreferLocalSSD()and use the default volume type in roachprod for the provider in case local SSD was not selected.The way
PreferLocalSSD()was implemented meant that most of the tests were actually running on local SSDs (when available on the machine type), leading to a gap in the testing strategy with regards to volume types.This patch brings the new ClusterSpec option
RandomizeVolumeType(). In case volume type is not forced and neitherPreferLocalSSD()orDisableLocalSSD()are specified, specifyingRandomizeVolumeType()will take precendence over the--local-ssdargument and will randomly select a volume type from those available in the targeted provider:Note: volume type randomization gives the same weight to all options.
This patch also introduces a random chance of provisioning XFS as a filesystem via the option
RandomlyUseXfs().The option is built in the same way as
RandomlyUseZfs(), granting a 20% chance of XFS if present.If both
RandomlyUseZfs()andRandomlyUseXfs()are used, they both get a 20% chance, leaving 60% chance for the default ext4.All/most of the KV tests, and a few admission-control are switched to volume type/filesystem randomization as requested in this issue.
Epic: none
Fixes: 146661
Release note: None
Release justification: test change only