fix: replace flaky Cloudflare test with reliable httpbin.org #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace flaky Cloudflare-based test with httpbin.org/headers which reliably echoes back received headers. This allows us to directly verify that httpjail corrects mismatched Host headers without depending on external service blocking behavior (which was inconsistent across datacenters). The new approach: 1. Tests what we control: httpjail's Host header correction 2. Uses reliable service: httpbin.org simply echoes headers 3. Has clear assertions: directly checks Host header values 4. No flakiness: doesn't rely on varying security policies Fixes the test failure that occurred because Cloudflare stopped consistently blocking mismatched Host headers (error 1034).
ammario
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
test_host_header_securitytest was flaky because it relied on Cloudflare consistently blocking mismatched Host headers (error 1034), but Cloudflare's behavior varies across datacenters and has become inconsistent.Solution
Replace the Cloudflare-based test with httpbin.org/headers which reliably echoes back received headers. This allows us to directly verify that httpjail corrects mismatched Host headers without depending on external service blocking behavior.
The new approach:
Testing
cargo test --profile fast --test weak_integration test_host_header_securityAll tests pass reliably without depending on unpredictable external service behavior.
Related to #57