Feedback #1
Open
Feedback #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jade branch
- Only render the issues list if it has something (Will prevent error when trying to map empty list). - Add initial state for searchTerm to match with what is showing. - Simplify error print to console when there's a error when fetching data.
commit c44ed18 Author: Thang Le Quang <[email protected]> Date: Sun Jan 10 00:47:07 2021 +0700 Add fuzzy matching (optional feature #4) commit d95986b Author: Thang Le Quang <[email protected]> Date: Sat Jan 9 23:59:16 2021 +0700 Add basic loading indicator commit 493fc9b Author: Thang Le Quang <[email protected]> Date: Sat Jan 9 23:57:31 2021 +0700 Add some callbacks to prevent bugs - Only render the issues list if it has something (Will prevent error when trying to map empty list). - Add initial state for searchTerm to match with what is showing. - Simplify error print to console when there's a error when fetching data.
…to overflow:scroll, and added other minor changes
- The issue's title will have the same style as app's title. - Use BEM methodology http://getbem.com/
- Remove padding of ul.issues. - Shrink the avatar. - Truncate the issue's body. - Change label's color based on brightness.
Add loading text and fuzzy matching
Add issue modal
…pdated layout style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @nngocjade @tuanle291100 @lethang7794 @halemmy @legobitna