Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
a61ea46
Setting up GitHub Classroom Feedback
chug2k Jan 8, 2021
4390fb8
pushing part 1 of charle's code
nngocjade Jan 8, 2021
0263d08
Ignore stupid cache file from ESLint
lethang7794 Jan 8, 2021
941b622
Update package-lock.json
lethang7794 Jan 8, 2021
6708365
added navBar styles
nngocjade Jan 8, 2021
b286548
Add Navbar
nngocjade Jan 8, 2021
130aecb
modified .eslintcache
nngocjade Jan 8, 2021
e2255d5
adding navbar styles
nngocjade Jan 8, 2021
0d8046e
styled searchForm UI
nngocjade Jan 9, 2021
1f82569
Handle response's errors and fetch's error
lethang7794 Jan 9, 2021
8931197
restyled searchForm width and button color
nngocjade Jan 9, 2021
0bdc10d
Merge branch 'main' into jadeBranch
nngocjade Jan 9, 2021
c4a3940
Merge pull request #3 from coderschool-ftw/jadeBranch
nngocjade Jan 9, 2021
681544e
Add basic ErrorMessage component
lethang7794 Jan 9, 2021
9f70225
Merge remote-tracking branch 'origin/ThangBranch' into main
lethang7794 Jan 9, 2021
374f6a0
Merge branch 'main' into basicErrorHandle
lethang7794 Jan 9, 2021
6a6782e
Merge branch 'basicErrorHandle'
lethang7794 Jan 9, 2021
16af5f1
reformated issueList and added more content
nngocjade Jan 9, 2021
493fc9b
Add some callbacks to prevent bugs
lethang7794 Jan 9, 2021
d95986b
Add basic loading indicator
lethang7794 Jan 9, 2021
c44ed18
Add fuzzy matching (optional feature #4)
lethang7794 Jan 9, 2021
f6bc1d9
Squashed commit of the following:
lethang7794 Jan 9, 2021
402ccdb
Fix some small bugs, delete duplicate things
lethang7794 Jan 9, 2021
d4ecfdb
Extract Issue component, add Label component
lethang7794 Jan 9, 2021
e65e313
Use LocalStorage to store searchTerm
lethang7794 Jan 9, 2021
f94b2bc
q3 UI done for now
nngocjade Jan 10, 2021
68a9438
updated user-id color and description font-size
nngocjade Jan 10, 2021
711dbe3
repositioned searchform and main title to fixed, changed description …
nngocjade Jan 10, 2021
dcb2e65
Prevent unexpected behavior with css selector
lethang7794 Jan 10, 2021
276e008
Prevent changing layout cause by unloaded image
lethang7794 Jan 10, 2021
b9642ba
Reformat issues list and issue item, label
lethang7794 Jan 10, 2021
eff5890
Merge pull request #5 from coderschool-ftw/loadingSpinner-fuzzyMathing
lethang7794 Jan 10, 2021
db16b4b
Add issue modal
tuanle291100 Jan 10, 2021
bf3c2fd
Merge pull request #6 from coderschool-ftw/tuan-modal
lethang7794 Jan 10, 2021
99e9f4b
added modal, added loading spinner(not working, need to debug), and u…
nngocjade Jan 10, 2021
e8dc6f1
Merge branch 'jadeBranch'
lethang7794 Jan 10, 2021
cc14d57
Merge branch 'main' of https://github.com/coderschool-ftw/github-issu…
lethang7794 Jan 10, 2021
d1ab955
Merge branch 'main' into Thang-Issue
lethang7794 Jan 10, 2021
c3c9dd8
Format issue modal
lethang7794 Jan 10, 2021
ef95ea4
Merge branch 'Thang-Issue'
lethang7794 Jan 10, 2021
040518a
Update README file, format error message
lethang7794 Jan 10, 2021
b1bd8f3
Fix overlayed sticky search bar
lethang7794 Jan 11, 2021
2c69bc1
Keep issue's content inside the border
lethang7794 Jan 11, 2021
98927d5
Update README.md
nngocjade Jan 11, 2021
b45774f
Update App.js
nngocjade Jan 11, 2021
51cbda2
Update README.md
nngocjade Jan 11, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintcache

This file was deleted.

1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@
npm-debug.log*
yarn-debug.log*
yarn-error.log*
.eslintcache
File renamed without changes.
37 changes: 21 additions & 16 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,28 +1,29 @@
# CoderSchool FTW - * GitHub Project Team Name *
# CoderSchool FTW - _GitHub Issues Team 1_

Created with love by: `teammates.map(teammate => teammate.name)`
View online at: `Your URL here`
One or two sentence summary of your project, anything fun that you liked.
Created with love by: `Jade Ha Tuan Thang`

View online at: [github-issue-team1.netlify.app](github-issue-team1.netlify.app)

<!-- One or two sentence summary of your project, anything fun that you liked. -->

## Video Walkthrough

Here's a walkthrough of implemented user stories.
<!-- Here's a walkthrough of implemented user stories.

To create a GIF, use [LiceCap](http://www.cockos.com/licecap/), [RecordIt](http://www.recordit.co), or [Loom](http://www.useloom.com), and link the image here in the markdown.

```
<img src='http://i.imgur.com/link/to/your/gif/file.gif' title='Video Walkthrough' width='' alt='Video Walkthrough' />
```

```-->

## User Stories

The following **required** functionalities are completed:

- [ ] The user can enter a repository in a search bar, click "search", and see the associated issues. The repository should be of the format `owner/repo-name`, e.g. `facebook/react`.
- [ ] If the repository does not exist, the user should see a proper error message.
- [ ] The user should be able to see the following information for each issue:
- [x] The user can enter a repository in a search bar, click "search", and see the associated issues. The repository should be of the format `owner/repo-name`, e.g. `facebook/react`.
- [x] If the repository does not exist, the user should see a proper error message.
- [x] The user should be able to see the following information for each issue:
- Issue Title with Number of the issue
- Owner of the Issue
- Owner Avatar
Expand All @@ -34,21 +35,21 @@ The following **required** functionalities are completed:
The following **optional** features are implemented:

- [ ] The user can see more details (**[including 5 comments of the issue](https://developer.github.com/v3/issues/comments/)**) in a modal that's opened by clicking on the title of the issue.
- [ ] The user should be able to see the body of the issue rendered in markdown. (Hint: [react-markdown](https://github.com/rexxars/react-markdown))
- [ ] Fetching is an asynchronous operation, so you should display a loading [spinner](https://www.npmjs.com/package/react-spinners) whenever the app loads data, and hide it once the corresponding API call has been completed.
- [ ] Input Fuzzy Matching: the user should be able to type in either https://github.com/facebook/react or facebook/react, BOTH should work.
- [x] The user should be able to see the body of the issue rendered in markdown. (Hint: [react-markdown](https://github.com/rexxars/react-markdown))
- [x] Fetching is an asynchronous operation, so you should display a loading [spinner](https://www.npmjs.com/package/react-spinners) whenever the app loads data, and hide it once the corresponding API call has been completed.
- [x] Input Fuzzy Matching: the user should be able to type in either https://github.com/facebook/react or facebook/react, BOTH should work.
- [ ] In the Issue Detail Modal, let implement an **infinite pagination** with a "Show More" button: Fetch 5 more comments whenever user clicks on the button. The button is disabled or hidden when all the comments have been loaded.
- [ ] Users can create a new issue. (**Danger Warning**: If you attempt this task, please do so on a private repository. Don't spam the official facebook/react repo!)

The following **additional** features are implemented:

* [x] List anything else cool you did
- [x] Change label's text color depends on background color.

## Time Spent and Lessons Learned

Time spent: **X** hours spent in total.

Describe any challenges encountered while building the app.
<!-- Describe any challenges encountered while building the app. -->

## License

Expand All @@ -65,3 +66,7 @@ Describe any challenges encountered while building the app.
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

```

```
Loading