Add indexer to index authors from a blog post #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericof
approved these changes
Jan 29, 2024
davisagli
reviewed
Jan 30, 2024
| author = searchResult[0].getObject() | ||
|
|
||
| if author is not None: | ||
| authors.append(author.title) |
There was a problem hiding this comment.
@jonaspiterek @ericof What problem are you trying to solve by adding an index of author names? It may be necessary, but keep in mind that if the author is edited later to fix a typo in the person's name, that will not automatically reindex all their blog posts.
Also: You don't need to use getObject here, which does unnecessary work. The item's title is available from the catalog brain object that is part of the results. (searchResult[0].Title)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.