-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indexer to index authors from a blog post #52
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
- Add indexer for indexing authors from a blog post [@jonaspiterek] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,4 +11,9 @@ | |
name="blog_uid" | ||
/> | ||
|
||
<adapter | ||
factory=".post.post_authors" | ||
name="post_authors" | ||
/> | ||
|
||
</configure> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,26 @@ | ||
from collective.blog.content.post import IPost | ||
from collective.blog.content.post import Post | ||
from plone import api | ||
from plone.indexer import indexer | ||
|
||
|
||
@indexer(IPost) | ||
def blog_post_indexer(obj: Post): | ||
"""Return blog uuid.""" | ||
return obj.blog_uid() | ||
|
||
|
||
@indexer(IPost) | ||
def post_authors(obj: Post): | ||
"""Returns the authors of a blog post.""" | ||
authors = [] | ||
uids = obj.creators | ||
for uid in uids: | ||
searchResult = api.content.find(portal_type="Author", UID=uid) | ||
if len(searchResult) > 0: | ||
author = searchResult[0].getObject() | ||
|
||
if author is not None: | ||
authors.append(author.title) | ||
|
||
return authors |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
from collective.blog import logger | ||
from plone import api | ||
from Products.GenericSetup.tool import SetupTool | ||
|
||
|
||
def recatalog_post_authors(setup_tool: SetupTool): | ||
"""Recatalog Posts.""" | ||
with api.env.adopt_roles(["Manager"]): | ||
brains = api.content.find(portal_type=["Post"]) | ||
total = len(brains) | ||
logger.info(f"Recatalog {total} items") | ||
for brain in brains: | ||
obj = brain.getObject() | ||
obj.reindexObject(idxs=["post_authors"]) | ||
logger.info("Reindexed post_authors") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonaspiterek @ericof What problem are you trying to solve by adding an index of author names? It may be necessary, but keep in mind that if the author is edited later to fix a typo in the person's name, that will not automatically reindex all their blog posts.
Also: You don't need to use getObject here, which does unnecessary work. The item's title is available from the catalog brain object that is part of the results. (searchResult[0].Title)