Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for loadListing on outputBinding. #69

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

tetron
Copy link
Member

@tetron tetron commented Dec 3, 2020

No description provided.

mr-c
mr-c previously approved these changes Dec 3, 2020
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign your commits :-)

The base branch requires all commits to be signed.

@tetron
Copy link
Member Author

tetron commented Dec 4, 2020

Argh, I don't understand why some commits are auto-signed by github and some are not.

@mr-c
Copy link
Member

mr-c commented Dec 5, 2020

@tetron if you make the edit in the browser it is autosigned. Using git you need to follow https://docs.github.com/articles/about-gpg/

@mr-c mr-c merged commit fe6b8dd into main Dec 7, 2020
@mr-c mr-c deleted the test-outputBinding-loadListing branch December 7, 2020 10:51
@tom-tan
Copy link
Member

tom-tan commented Dec 7, 2020

Please add id field.

@mr-c
Copy link
Member

mr-c commented Dec 7, 2020

Please add id field.

Whoops! Thank you for catching that. @tom-tan can you send us a PR to automatically check for well-formed additions to the conformance tests?

@mr-c
Copy link
Member

mr-c commented Dec 7, 2020

Though as noted in #54 the id fields are already partially wrong. And according to common-workflow-language/cwltest#110 we want to get rid of numerical ids altogether

@tom-tan
Copy link
Member

tom-tan commented Dec 7, 2020

I agree with replacing id with label if it can be unique in CWL v1.0, v1.1, v1.2 and later and if it is easy to be specified from cwltest.
The unique ids will help the platform developers migrating their platforms from v1.0 to v1.1 (also from v1.1 to v1.2, of course).

Anyway, can I send a request or is it better to wait for solving common-workflow-language/cwltest#110?

@mr-c
Copy link
Member

mr-c commented Dec 7, 2020

Anyway, can I send a request or is it better to wait for solving common-workflow-language/cwltest#110?

Looks like we need to wait for common-workflow-language/cwltest#110 first, but you could help us start by doing items 3, 4, and 5 for cwltest?

@tom-tan
Copy link
Member

tom-tan commented Dec 7, 2020

OK, I will work on common-workflow-language/cwltest#110 and try to write a schema for the conformance test (I hope JSON schema works with YAML...).

@mr-c
Copy link
Member

mr-c commented Dec 7, 2020 via email

@tetron
Copy link
Member Author

tetron commented Dec 7, 2020

@tom-tan I did that already https://github.com/common-workflow-language/cwltest/blob/main/cwltest/cwltest-schema.yml

@tom-tan
Copy link
Member

tom-tan commented Dec 9, 2020

Can I add a setting for Github Actions or do you have other preferable CI services for this repository?

@mr-c
Copy link
Member

mr-c commented Dec 9, 2020

Can I add a setting for Github Actions or do you have other preferable CI services for this repository?

GitHub Actions works for us. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants