Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tt-metalium #28854
base: main
Are you sure you want to change the base?
Adding tt-metalium #28854
Changes from 31 commits
aad8e55
88b02fd
4cbe34f
43ca25a
6fb0f13
d0dada2
b935312
9bcf248
f7a7349
605a5f8
5d06a8c
8ccf7fc
dc68535
d1b88a2
f522568
e858c4b
2d3f737
bbc7d92
04d3263
ff638a1
8678be7
293f3f7
65387d1
9842d1d
163f19b
2a3032d
ed3b681
3246ece
de4c472
9924066
37eb9c7
a5f7a46
4902999
29beb3e
f981c08
60c4a31
e41eca4
5d4b69b
f10d051
7c57ba6
f56c47f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally you shouldn't add
libzlib
at runtime, but putzlib
into host. Your commit message in ed3b681 says "RISCV compiler binaries" - where are these coming from and how do they come into play?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/tenstorrent/tt-metal/blob/8b2c6cd16a27bd54675a018dc8a66013af3181e3/tt_metal/hw/CMakeLists.txt#L34
Released binaries are fetched At tt-metalium build time. They are used to compile some static riscv firmware.
They are used at runtime to jit compile kernel code that is later launched on riscv accelerators.
The compiler binaries are dynamically linking some things.
I realize after you highlight it, that this is not ideal for conda packaging.
Source is here:
https://github.com/tenstorrent/sfpi
I guess I could ask them to static link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I’d like to avoid creating a conda package for that repo…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we don't have riscv support at the moment, I'd say this is probably alright for now, but still CC @conda-forge/core if someone has other opinions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping again for comments about whether and how we want to accept binary repackaging of cross-compilers for an architecture we don't support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isuruf they are all listed at the top of the README here: https://github.com/tenstorrent/sfpi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add all the license of the vendored packages here, both as the verbatim license file copied into the recipe, as well as referenced in the package metadata. Here's an example of what I mean: conda-forge/pytorch-cpu-feedstock@9a36bd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h-vetinari Thanks for the example, I think this is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's more libraries still not covered. Also, CI is red. 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put the license file in the wrong location… smh