Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tt-metalium #28854

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Adding tt-metalium #28854

wants to merge 41 commits into from

Conversation

blozano-tt
Copy link

@blozano-tt blozano-tt commented Jan 17, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/tt-metalium/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: afuller-TT. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 17, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tt-metalium/meta.yaml) and found some lint.

Here's what I've got...

For recipes/tt-metalium/meta.yaml:

  • ❌ The source section contained an unexpected subsection name. git_submodules is not a valid subsection name.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12927119653. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 23, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tt-metalium/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/tt-metalium/meta.yaml:

  • ℹ️ Please depend on pytorch directly, in order to avoid forcing CUDA users to downgrade to the CPU version for no reason.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12944803893. Examine the logs at this URL for more detail.

@blozano-tt
Copy link
Author

blozano-tt commented Jan 23, 2025

@h-vetinari would you be willing to review this? (Pretty please)

The C++ code builds.

I still need to iron out the python wheel generation and installation, but I believe all pieces are in place (just might be missing some python module dependencies).

@blozano-tt
Copy link
Author

Things are now in good shape.

I have two action items left.

  • confirm all necessary files are packaged in site-packages after recipe build
  • switch recipe back to using tarball source

Will update when completed

@h-vetinari
Copy link
Member

confirm all necessary files are packaged in site-packages after recipe build

At the bottom of the logs there's a fold out section called Inspecting artifacts where you can see everything that ends up in the final package

@blozano-tt
Copy link
Author

I think this recipe is good to go.
I updated it to use the latest release candidate, which has the bugfix for some python packaging issue.

recipes/tt-metalium/build.sh Outdated Show resolved Hide resolved
recipes/tt-metalium/meta.yaml Outdated Show resolved Hide resolved
recipes/tt-metalium/meta.yaml Show resolved Hide resolved
- python
- numactl
- libhwloc
- libzlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping again for comments about whether and how we want to accept binary repackaging of cross-compilers for an architecture we don't support.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please break out sfpi into a separate output

recipes/tt-metalium/meta.yaml Outdated Show resolved Hide resolved
recipes/tt-metalium/build.sh Outdated Show resolved Hide resolved
- python
- numactl
- libhwloc
- libzlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any major concerns with just packaging the binary?

Aside from binary repackaging (which I think could be acceptable, given that we have nothing regarding risc-v support so far), my concern is not stuffing things into site-packages that have no business being there.

Everything not python-related should go into a separate package (can be in the same recipe though), which tt-metallium then depends on.

recipes/tt-metalium/meta.yaml Show resolved Hide resolved
Co-authored-by: h-vetinari <[email protected]>
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13087616954. Examine the logs at this URL for more detail.

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions.

File-specific lints and/or hints:

  • recipes/tt-metalium/meta.yaml:
    • hints:
      • It looks like you are submitting a multi-output recipe. In these cases, the correct name for the feedstock is ambiguous, and our infrastructure defaults to the top-level package.name field. Please add a feedstock-name entry in the extra section.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tt-metalium/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/tt-metalium/meta.yaml:

  • ℹ️ It looks like the 'tt-metalium-src' output doesn't have any tests.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13087676472. Examine the logs at this URL for more detail.

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tt-metalium/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants