-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tt-metalium #28854
base: main
Are you sure you want to change the base?
Adding tt-metalium #28854
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tt-metalium/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12927119653. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tt-metalium/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12944803893. Examine the logs at this URL for more detail. |
@h-vetinari would you be willing to review this? (Pretty please) The C++ code builds. I still need to iron out the python wheel generation and installation, but I believe all pieces are in place (just might be missing some python module dependencies). |
Things are now in good shape. I have two action items left.
Will update when completed |
At the bottom of the logs there's a fold out section called |
I think this recipe is good to go. |
- python | ||
- numactl | ||
- libhwloc | ||
- libzlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping again for comments about whether and how we want to accept binary repackaging of cross-compilers for an architecture we don't support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please break out sfpi into a separate output
- python | ||
- numactl | ||
- libhwloc | ||
- libzlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any major concerns with just packaging the binary?
Aside from binary repackaging (which I think could be acceptable, given that we have nothing regarding risc-v support so far), my concern is not stuffing things into site-packages
that have no business being there.
Everything not python-related should go into a separate package (can be in the same recipe though), which tt-metallium
then depends on.
Co-authored-by: h-vetinari <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13087616954. Examine the logs at this URL for more detail. |
Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tt-metalium/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13087676472. Examine the logs at this URL for more detail. |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).