Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tt-metalium #28854

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
aad8e55
Add first shot
blozano-tt Jan 17, 2025
88b02fd
Adjust
blozano-tt Jan 17, 2025
4cbe34f
Progress
blozano-tt Jan 18, 2025
43ca25a
dunno
blozano-tt Jan 22, 2025
6fb0f13
dunno
blozano-tt Jan 22, 2025
d0dada2
Fix
blozano-tt Jan 22, 2025
b935312
Add libmpc as a dependency for sfpi
blozano-tt Jan 22, 2025
9bcf248
Try LD_LIBRARY_PATH
blozano-tt Jan 22, 2025
f7a7349
Try higher sysroot
blozano-tt Jan 22, 2025
605a5f8
Not sure
blozano-tt Jan 22, 2025
5d06a8c
Add missing dep zlib
blozano-tt Jan 22, 2025
8ccf7fc
Update to build and install python wheel
blozano-tt Jan 22, 2025
dc68535
Add python build deps
blozano-tt Jan 23, 2025
d1b88a2
Please
blozano-tt Jan 23, 2025
f522568
Reduce load on CPU
blozano-tt Jan 23, 2025
e858c4b
Try restricting python
blozano-tt Jan 23, 2025
2d3f737
Progress maybe
blozano-tt Jan 23, 2025
bbc7d92
Fix skip issue
blozano-tt Jan 23, 2025
04d3263
Fix python module installation hopefully
blozano-tt Jan 23, 2025
ff638a1
Merge branch 'main' into tt-metalium
blozano-tt Jan 23, 2025
8678be7
Hacks to fix python packaging maybe
blozano-tt Jan 24, 2025
293f3f7
Merge branch 'tt-metalium' of https://github.com/blozano-tt/staged-re…
blozano-tt Jan 24, 2025
65387d1
Merge branch 'main' into tt-metalium
jakirkham Jan 24, 2025
9842d1d
Update recipes/tt-metalium/meta.yaml
blozano-tt Jan 24, 2025
163f19b
Update recipes/tt-metalium/meta.yaml
blozano-tt Jan 24, 2025
2a3032d
Update meta.yaml
blozano-tt Jan 24, 2025
ed3b681
Add missing runtime deps for RISCV compiler binaries
blozano-tt Jan 24, 2025
3246ece
Use branch temporarily, relax other constraints
blozano-tt Jan 25, 2025
de4c472
Enable only python 3.10
blozano-tt Jan 26, 2025
9924066
Move back to tarball with latest code
blozano-tt Jan 29, 2025
37eb9c7
Update url logic
blozano-tt Jan 30, 2025
a5f7a46
Update recipes/tt-metalium/build.sh
blozano-tt Jan 30, 2025
4902999
Update recipes/tt-metalium/meta.yaml
blozano-tt Jan 30, 2025
29beb3e
Create multiple outputs to keep cpp sources seperate
blozano-tt Feb 1, 2025
f981c08
Update meta.yaml
blozano-tt Feb 1, 2025
60c4a31
Revert "Update meta.yaml"
blozano-tt Feb 1, 2025
e41eca4
Revert "Create multiple outputs to keep cpp sources seperate"
blozano-tt Feb 1, 2025
5d4b69b
Keep non python sources separate from site-packages
blozano-tt Feb 11, 2025
f10d051
Move extraneous files
blozano-tt Feb 12, 2025
7c57ba6
Update build.sh
blozano-tt Feb 12, 2025
f56c47f
Add license for sfpi
blozano-tt Feb 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions recipes/tt-metalium/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
#!/bin/env/bash
set -e

# Needed so that sfpi can be invoked at build time to generate object files
# sfpi links libmpc.so at runtime
export LD_LIBRARY_PATH=$PREFIX/lib

# Avoid overloading build machine processors and memory
export NUM_PROCS=$((CPU_COUNT / 2))

# Needed by python setup.py
export TT_FROM_PRECOMPILED_DIR=$SRC_DIR

cmake \
$CMAKE_ARGS \
-G Ninja \
-S $SRC_DIR \
-B $SRC_DIR/build \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_SKIP_INSTALL_RPATH=ON

cmake --build $SRC_DIR/build --parallel $NUM_PROCS

cmake --install $SRC_DIR/build

# Warning - HACK!
mkdir -p $SRC_DIR/build/lib
cp $PREFIX/lib/_ttnn.so $SRC_DIR/build/lib/
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved

pip install --no-deps $SRC_DIR
4 changes: 4 additions & 0 deletions recipes/tt-metalium/conda_build_config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# This package uses some RISCV defines from the sysroot "elf.h"
# These defines are not available in the old sysroot
c_stdlib_version: # [linux]
- 2.34 # [linux]
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved
73 changes: 73 additions & 0 deletions recipes/tt-metalium/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
{% set name = "tt-metalium" %}
{% set version = "0.56.0" %}
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://github.com/tenstorrent/tt-metal/releases/download/v{{ version }}-rc1/tt-metalium.tar.gz
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved
sha256: 319f8c8f5b3ce98ef7db0c0e230cd37aca339b06ece98d923daadf4d86b27465

# Skipping build for other python versions due to timeout in staging CI
# Will enable more python versions after merge
build:
number: 0
skip: true # [not linux or py!=310]
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved

requirements:
build:
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- {{ stdlib("c") }}
- cmake
- ninja
- git

host:
- python
- pip
- wheel
- setuptools
- numactl
- libhwloc
- mpc
- numpy
- loguru
- networkx
- pytorch
- python-graphviz

run:
- python
- numactl
- libhwloc
- libzlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally you shouldn't add libzlib at runtime, but put zlib into host. Your commit message in ed3b681 says "RISCV compiler binaries" - where are these coming from and how do they come into play?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/tenstorrent/tt-metal/blob/8b2c6cd16a27bd54675a018dc8a66013af3181e3/tt_metal/hw/CMakeLists.txt#L34

Released binaries are fetched At tt-metalium build time. They are used to compile some static riscv firmware.
They are used at runtime to jit compile kernel code that is later launched on riscv accelerators.

The compiler binaries are dynamically linking some things.

I realize after you highlight it, that this is not ideal for conda packaging.

Source is here:

https://github.com/tenstorrent/sfpi

I guess I could ask them to static link.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I’d like to avoid creating a conda package for that repo…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Released binaries are fetched [at] build time. They are used to compile some static riscv firmware.
They are used at runtime to jit compile kernel code that is later launched on riscv accelerators.

Given that we don't have riscv support at the moment, I'd say this is probably alright for now, but still CC @conda-forge/core if someone has other opinions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping again for comments about whether and how we want to accept binary repackaging of cross-compilers for an architecture we don't support.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuruf they are all listed at the top of the README here: https://github.com/tenstorrent/sfpi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add all the license of the vendored packages here, both as the verbatim license file copied into the recipe, as well as referenced in the package metadata. Here's an example of what I mean: conda-forge/pytorch-cpu-feedstock@9a36bd4

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-vetinari Thanks for the example, I think this is done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCC, Binutils, Newlib, Qemu and Dejagnu are (naturally) released under their own licenses.

I think there's more libraries still not covered. Also, CI is red. 🙃

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the license file in the wrong location… smh

- mpfr
- gmp
- mpc
- numpy
- loguru
- networkx
- pytorch
- python-graphviz

test:
imports:
- ttnn
blozano-tt marked this conversation as resolved.
Show resolved Hide resolved

about:
home: https://github.com/tenstorrent/tt-metal
summary: 'Simple, fast, extensible runtime libraries for Tenstorrent Hardware'
description: |
TT-NN operator library, and TT-Metalium low level kernel programming model.
license: Apache-2.0
license_family: Apache
license_file: LICENSE
doc_url: https://docs.tenstorrent.com/tt-metalium/latest
dev_url: https://github.com/tenstorrent/tt-metal

extra:
recipe-maintainers:
- blozano-tt
- afuller-TT
h-vetinari marked this conversation as resolved.
Show resolved Hide resolved