Add reprostim #29029

vmdocua · 2025-02-04T22:32:40Z

Checklist

github-actions · 2025-02-04T22:34:02Z

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

recipes/reprostim/meta.yaml:
- lints:
  - The following maintainers have not yet confirmed that they are willing to be listed here: yarikoptic. Please ask them to comment on this PR if they are.

conda-forge-admin · 2025-02-04T22:34:17Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/reprostim/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/reprostim/meta.yaml:

ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13146118436. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-02-05T14:25:14Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/reprostim/meta.yaml) and found it was in an excellent condition.

yarikoptic · 2025-02-05T20:33:06Z

recipes/reprostim/meta.yaml

+
+extra:
+  recipe-maintainers:
+    - yarikoptic


I confirm to agree to co-maintain this recipe!

github-actions · 2025-02-07T10:18:59Z

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

conda-forge-admin · 2025-02-07T17:45:43Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/reprostim/meta.yaml) and found some lint.

Here's what I've got...

For recipes/reprostim/meta.yaml:

❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [37, 39]
❌ Non noarch packages should have python requirement without any version constraints.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13205273913. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-02-08T08:04:11Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/reprostim/meta.yaml) and found it was in an excellent condition.

yarikoptic · 2025-02-10T14:27:42Z

@conda-forge/staged-recipes I think this recipe is ready happen someone has cycles to review/feedback/merge.

Cheers

github-actions · 2025-02-10T14:27:55Z

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

yarikoptic · 2025-02-10T14:48:32Z

@conda-forge/help-python I think this recipe is ready happen someone has cycles to review/feedback/merge.

ocefpaf · 2025-02-10T14:56:37Z

recipes/reprostim/meta.yaml

+  sha256: f735714a725998816617df9ab84c9e0f79e6749544b0ab1d27d0fd0c5672d6c2
+
+build:
+  skip: True  # [win]


Looks like this one could be noarch.

It is OK for noarch package to fails on Windows with a missing dependency. We prefer noarch b/c it is faster to build and the package will be ready when the missing dependency is available on Windows.

synapticarbors · 2025-02-10T14:55:05Z

recipes/reprostim/meta.yaml

+  sha256: f735714a725998816617df9ab84c9e0f79e6749544b0ab1d27d0fd0c5672d6c2
+
+build:
+  skip: True  # [win]


It seems like this should be noarch: python. I can see you were having issues with dependency availability on windows, but typically we ignore those since that's an ecosystem issue rather than an issue with this package.

That is to say, if all of the CI is passing except windows and the windows issue is just that a dependency isn't available, then we will merge it if it's a noarch: python package.

Done, switched to noarch.

synapticarbors · 2025-02-10T14:55:54Z

recipes/reprostim/meta.yaml

+    - numpy >=1.26.4
+    - qrcode >=8.0
+    - opencv >=4.9.0
+    - zbar  # [not win]


This is not a direct dependency and should be pulled in by pyzbar

Done, zbar removed + pyzbar downgraded to v.0.1.8, as the latest version try to install zbar DLL and package which physically not exists at all for Windows (as was reprorted by maintainers). Interesting enough how conda-forge pyzbar v0.1.9 updated recipe and passed check in conda like this windows build w/o zbar, but this is probably another story..

This change was not enough to fix build, as looks like under Windows-based python we need to explicitly specify entry point, as otherwise it fails in contrast to Linux/macOS.

synapticarbors · 2025-02-10T14:56:06Z

recipes/reprostim/meta.yaml

+
+test:
+  imports:
+    - reprostim  # [not win]


Remove win selectors.

Done, all selectors were removed.

…ports in tests as were recommended.

conda-forge-admin · 2025-02-10T20:40:07Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/reprostim/meta.yaml) and found some lint.

Here's what I've got...

For recipes/reprostim/meta.yaml:

❌ noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13250915510. Examine the logs at this URL for more detail.}

…he python version."

The following package could not be installed pyzbar >=0.1.9 * is not installable because it requires zbar =* *, which does not exist (perhaps a missing channel).

…e run section of recipe, you should usually use python >={{ python_min }} for the python entry"

…Noarch package contains binary script: reprostim.exe

conda-forge-admin · 2025-02-10T22:15:09Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/reprostim/meta.yaml) and found it was in an excellent condition.

…ts under noarch.

…try point.

…g work in "Build win_64 win" job w/o errors under noarch.

vmdocua · 2025-02-10T23:54:40Z

Just for information, on the same plate, created issue at pyzbar-feedstock #5 as well.

Created recipes/reprostim/meta.yaml

86e7eab

vmdocua changed the title ~~Adding reprostim~~ Add recipe for reprostim Feb 4, 2025

Normalized reprostim recipe dependencies.

3ba04a5

vmdocua changed the title ~~Add recipe for reprostim~~ Add reprostim Feb 5, 2025

yarikoptic reviewed Feb 5, 2025

View reviewed changes

Update opencv-python dependency.

97f81aa

vmdocua added 2 commits February 7, 2025 12:24

Update opencv-python dependency.

b510ed5

Update tests and version to be draft 0.7.6 .

57d597d

vmdocua mentioned this pull request Feb 7, 2025

Fixes basic tests execution under conda-forge. ReproNim/reprostim#137

Merged

vmdocua added 4 commits February 7, 2025 14:06

Fix tests and update version to be draft 0.7.7 .

119af41

Updated test dependencies.

f9e88a8

Updated test dependencies.

e2e3c46

Updated test dependencies.

fc63412

vmdocua mentioned this pull request Feb 7, 2025

Fixes basic tests execution under conda-forge #2 ReproNim/reprostim#138

Merged

vmdocua added 3 commits February 7, 2025 15:15

Updated version to 0.7.8.

fd197a9

Constrain to OSX or Linux only.

492d6b3

Exclude windows platform.

2430678

vmdocua added 4 commits February 7, 2025 19:49

Exclude windows platform.

42ddb16

Exclude tests on windows platform.

0363c68

Exclude tests on windows platform.

bc257c2

Exclude zbar on windows platform.

4bd2a22

vmdocua marked this pull request as ready for review February 8, 2025 08:19

github-actions bot added review-requested staged-recipes labels Feb 10, 2025

github-actions bot added the python label Feb 10, 2025

ocefpaf reviewed Feb 10, 2025

View reviewed changes

synapticarbors requested changes Feb 10, 2025

View reviewed changes

Restored noarch, removed zbar bin dependency and enabled reprostim im…

456ac22

…ports in tests as were recommended.

vmdocua added 5 commits February 10, 2025 22:42

Fixed "noarch: python recipes are required to have a lower bound on t…

1b7cd3e

…he python version."

Try to fix under noarch error in "Build win_64 win" job:

b20bc22

The following package could not be installed pyzbar >=0.1.9 * is not installable because it requires zbar =* *, which does not exist (perhaps a missing channel).

Disable pyzbar dependency in windows atm and fix linter error "For th…

da2fc80

…e run section of recipe, you should usually use python >={{ python_min }} for the python entry"

Build win_64 win failed: conda_build.exceptions.CondaBuildUserError: …

683ee42

…Noarch package contains binary script: reprostim.exe

Try early pyzbar version 0.1.8, noarch and removed all conda selectors.

c104dff

vmdocua added 4 commits February 11, 2025 00:36

Revert back pyzbar version 0.1.9, and try __linux and __osx constrain…

2344ebe

…ts under noarch.

Removed __linux and __osx constraints, pyzbar 0.1.8, and specified en…

dddac5f

…try point.

Now switch to the latest pyzbar 0.1.9.

81b0d89

Finally stick to the older pyzbar v0.1.8 + entry_points,as this confi…

43513b3

…g work in "Build win_64 win" job w/o errors under noarch.

vmdocua mentioned this pull request Feb 10, 2025

Conda-forge staged-recipes (Build win_64 win) job failed with pyzbar >=0.1.9 dependency conda-forge/pyzbar-feedstock#5

Open

vmdocua requested review from synapticarbors, yarikoptic and ocefpaf February 11, 2025 07:45

synapticarbors merged commit bf5cfc5 into conda-forge:main Feb 11, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add reprostim #29029

Add reprostim #29029

vmdocua commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025

conda-forge-admin commented Feb 4, 2025

conda-forge-admin commented Feb 5, 2025

yarikoptic Feb 5, 2025

github-actions bot commented Feb 7, 2025

conda-forge-admin commented Feb 7, 2025 •

edited

Loading

conda-forge-admin commented Feb 8, 2025

yarikoptic commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

yarikoptic commented Feb 10, 2025

ocefpaf Feb 10, 2025

synapticarbors Feb 10, 2025

synapticarbors Feb 10, 2025

vmdocua Feb 11, 2025

synapticarbors Feb 10, 2025

vmdocua Feb 11, 2025

synapticarbors Feb 10, 2025

vmdocua Feb 11, 2025

conda-forge-admin commented Feb 10, 2025 •

edited

Loading

conda-forge-admin commented Feb 10, 2025

vmdocua commented Feb 10, 2025

Add reprostim #29029

Add reprostim #29029

Conversation

vmdocua commented Feb 4, 2025 • edited Loading

github-actions bot commented Feb 4, 2025

conda-forge-admin commented Feb 4, 2025

conda-forge-admin commented Feb 5, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 7, 2025

conda-forge-admin commented Feb 7, 2025 • edited Loading

conda-forge-admin commented Feb 8, 2025

yarikoptic commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

yarikoptic commented Feb 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conda-forge-admin commented Feb 10, 2025 • edited Loading

conda-forge-admin commented Feb 10, 2025

vmdocua commented Feb 10, 2025

vmdocua commented Feb 4, 2025 •

edited

Loading

conda-forge-admin commented Feb 7, 2025 •

edited

Loading

conda-forge-admin commented Feb 10, 2025 •

edited

Loading