-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reprostim #29029
Add reprostim #29029
Changes from 16 commits
86e7eab
3ba04a5
97f81aa
b510ed5
57d597d
119af41
f9e88a8
e2e3c46
fc63412
fd197a9
492d6b3
2430678
42ddb16
0363c68
bc257c2
4bd2a22
456ac22
1b7cd3e
b20bc22
da2fc80
683ee42
c104dff
2344ebe
dddac5f
81b0d89
43513b3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
{% set name = "reprostim" %} | ||
{% set version = "0.7.8" %} | ||
|
||
package: | ||
name: {{ name|lower }} | ||
version: {{ version }} | ||
|
||
source: | ||
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/reprostim-{{ version }}.tar.gz | ||
sha256: f735714a725998816617df9ab84c9e0f79e6749544b0ab1d27d0fd0c5672d6c2 | ||
|
||
build: | ||
skip: True # [win] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like this one could be noarch. It is OK for noarch package to fails on Windows with a missing dependency. We prefer noarch b/c it is faster to build and the package will be ready when the missing dependency is available on Windows. |
||
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation | ||
number: 0 | ||
|
||
requirements: | ||
host: | ||
- python | ||
- setuptools >=46.4.0 | ||
- pip | ||
- hatchling | ||
- versioningit | ||
run: | ||
- python | ||
- click >=8.1.7 | ||
- click-didyoumean >=0.3.1 | ||
- pydantic >=2.7.1 | ||
- numpy >=1.26.4 | ||
- qrcode >=8.0 | ||
- opencv >=4.9.0 | ||
- zbar # [not win] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not a direct dependency and should be pulled in by There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, zbar removed + This change was not enough to fix build, as looks like under Windows-based python we need to explicitly specify entry point, as otherwise it fails in contrast to Linux/macOS. |
||
- pyzbar >=0.1.9 | ||
|
||
|
||
test: | ||
imports: | ||
- reprostim # [not win] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, all selectors were removed. |
||
commands: | ||
- python -m pytest -vv tests # [not win] | ||
requires: | ||
- python {{ python_min }} | ||
- pytest | ||
- pytest-cov | ||
- reedsolo >=1.7.0 | ||
- scipy | ||
source_files: | ||
- tests | ||
|
||
about: | ||
home: https://github.com/ReproNim/reprostim/ | ||
summary: ReproStim is a video capture and recording suite for neuroimaging and psychology experiments | ||
license: MIT | ||
license_family: MIT | ||
license_file: LICENSES/MIT.txt | ||
|
||
extra: | ||
recipe-maintainers: | ||
- yarikoptic | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I confirm to agree to co-maintain this recipe! |
||
- vmdocua |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this should be
noarch: python
. I can see you were having issues with dependency availability on windows, but typically we ignore those since that's an ecosystem issue rather than an issue with this package.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is to say, if all of the CI is passing except windows and the windows issue is just that a dependency isn't available, then we will merge it if it's a
noarch: python
package.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, switched to noarch.