Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reprostim #29029

Merged
merged 26 commits into from
Feb 11, 2025
Merged
Changes from 16 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
86e7eab
Created recipes/reprostim/meta.yaml
vmdocua Feb 4, 2025
3ba04a5
Normalized reprostim recipe dependencies.
vmdocua Feb 5, 2025
97f81aa
Update opencv-python dependency.
vmdocua Feb 7, 2025
b510ed5
Update opencv-python dependency.
vmdocua Feb 7, 2025
57d597d
Update tests and version to be draft 0.7.6 .
vmdocua Feb 7, 2025
119af41
Fix tests and update version to be draft 0.7.7 .
vmdocua Feb 7, 2025
f9e88a8
Updated test dependencies.
vmdocua Feb 7, 2025
e2e3c46
Updated test dependencies.
vmdocua Feb 7, 2025
fc63412
Updated test dependencies.
vmdocua Feb 7, 2025
fd197a9
Updated version to 0.7.8.
vmdocua Feb 7, 2025
492d6b3
Constrain to OSX or Linux only.
vmdocua Feb 7, 2025
2430678
Exclude windows platform.
vmdocua Feb 7, 2025
42ddb16
Exclude windows platform.
vmdocua Feb 7, 2025
0363c68
Exclude tests on windows platform.
vmdocua Feb 7, 2025
bc257c2
Exclude tests on windows platform.
vmdocua Feb 7, 2025
4bd2a22
Exclude zbar on windows platform.
vmdocua Feb 8, 2025
456ac22
Restored noarch, removed zbar bin dependency and enabled reprostim im…
vmdocua Feb 10, 2025
1b7cd3e
Fixed "noarch: python recipes are required to have a lower bound on t…
vmdocua Feb 10, 2025
b20bc22
Try to fix under noarch error in "Build win_64 win" job:
vmdocua Feb 10, 2025
da2fc80
Disable pyzbar dependency in windows atm and fix linter error "For th…
vmdocua Feb 10, 2025
683ee42
Build win_64 win failed: conda_build.exceptions.CondaBuildUserError: …
vmdocua Feb 10, 2025
c104dff
Try early pyzbar version 0.1.8, noarch and removed all conda selectors.
vmdocua Feb 10, 2025
2344ebe
Revert back pyzbar version 0.1.9, and try __linux and __osx constrai…
vmdocua Feb 10, 2025
dddac5f
Removed __linux and __osx constraints, pyzbar 0.1.8, and specified en…
vmdocua Feb 10, 2025
81b0d89
Now switch to the latest pyzbar 0.1.9.
vmdocua Feb 10, 2025
43513b3
Finally stick to the older pyzbar v0.1.8 + entry_points,as this confi…
vmdocua Feb 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions recipes/reprostim/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
{% set name = "reprostim" %}
{% set version = "0.7.8" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/reprostim-{{ version }}.tar.gz
sha256: f735714a725998816617df9ab84c9e0f79e6749544b0ab1d27d0fd0c5672d6c2

build:
skip: True # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this should be noarch: python. I can see you were having issues with dependency availability on windows, but typically we ignore those since that's an ecosystem issue rather than an issue with this package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is to say, if all of the CI is passing except windows and the windows issue is just that a dependency isn't available, then we will merge it if it's a noarch: python package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, switched to noarch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one could be noarch.

It is OK for noarch package to fails on Windows with a missing dependency. We prefer noarch b/c it is faster to build and the package will be ready when the missing dependency is available on Windows.

script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0

requirements:
host:
- python
- setuptools >=46.4.0
- pip
- hatchling
- versioningit
run:
- python
- click >=8.1.7
- click-didyoumean >=0.3.1
- pydantic >=2.7.1
- numpy >=1.26.4
- qrcode >=8.0
- opencv >=4.9.0
- zbar # [not win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a direct dependency and should be pulled in by pyzbar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, zbar removed + pyzbar downgraded to v.0.1.8, as the latest version try to install zbar DLL and package which physically not exists at all for Windows (as was reprorted by maintainers). Interesting enough how conda-forge pyzbar v0.1.9 updated recipe and passed check in conda like this windows build w/o zbar, but this is probably another story..

This change was not enough to fix build, as looks like under Windows-based python we need to explicitly specify entry point, as otherwise it fails in contrast to Linux/macOS.

- pyzbar >=0.1.9


test:
imports:
- reprostim # [not win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove win selectors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, all selectors were removed.

commands:
- python -m pytest -vv tests # [not win]
requires:
- python {{ python_min }}
- pytest
- pytest-cov
- reedsolo >=1.7.0
- scipy
source_files:
- tests

about:
home: https://github.com/ReproNim/reprostim/
summary: ReproStim is a video capture and recording suite for neuroimaging and psychology experiments
license: MIT
license_family: MIT
license_file: LICENSES/MIT.txt

extra:
recipe-maintainers:
- yarikoptic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm to agree to co-maintain this recipe!

- vmdocua