Skip to content

Conversation

@davidbrochart
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 29, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libadwaita/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/libadwaita/recipe.yaml:

  • ❌ The recipe must have some tests.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19815246962. Examine the logs at this URL for more detail.

@davidbrochart davidbrochart force-pushed the libadwaita branch 2 times, most recently from 88bd5e7 to f9bcc49 Compare November 29, 2025 17:48
@davidbrochart
Copy link
Member Author

The build fails with:

src/stylesheet/meson.build:88:40: ERROR: Dependency 'gio-2.0' tool variable 'glib_compile_resources' contains erroneous value: '$PREFIX/bin/glib-compile-resources'
This is a distributor issue -- please report it to your gio-2.0 provider.

Any idea @conda-forge/help-c-cpp ?

@davidbrochart
Copy link
Member Author

Now failing with ERROR: Program 'update-mime-database' not found or not executable 🤔

@danyeaw
Copy link
Member

danyeaw commented Nov 30, 2025

This is amazing that you are helping to package this @davidbrochart, thanks so much!

For the update-mime-database error, I think you need shared-mime-info as a build requirement.

Any reason not to go straight to latest 1.8.2 version?

I also maintain a patch for Windows to build libadwaita without AppStream support since AppStream uses features that aren't compatible with MSVC. It could always be a follow-up PR, but it would be amazing if this recipe supported Linux, macOS, and Windows.

@davidbrochart
Copy link
Member Author

For the update-mime-database error, I think you need shared-mime-info as a build requirement.

Are you sure? shared-mime-info doesn't seem to be a conda-forge package.

@danyeaw
Copy link
Member

danyeaw commented Dec 10, 2025

Hey @davidbrochart, I noticed in the build log:

 │ │ gtk| Program sassc found: NO
 │ │ subprojects/gtk/gtk/meson.build:737:10: ERROR: Program 'sassc' not found or not executable

libadwaita does depend on this for style sheets, I think you need libsass as a build requirement. I can also try to build this locally and help troubleshoot.

@davidbrochart
Copy link
Member Author

Thanks @danyeaw, I tried but https://github.com/conda-forge/libsass-feedstock is actually a Python binding of the libsass C/C++ library.
I think we will have to have different outputs in that feedstock.

@danyeaw
Copy link
Member

danyeaw commented Dec 21, 2025

Hi @davidbrochart, I just remembered that I also had a PR #30909 that was also trying to add libadwaita. I looked more at this and you are absolutely right about libsass being Python bindings. It looks like we'll need sassc and also libsass-lib (or libsass-native) whatever we want to call the actual libsass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants