-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add package libadwaita #31585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add package libadwaita #31585
Conversation
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libadwaita/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19815246962. Examine the logs at this URL for more detail. |
88bd5e7 to
f9bcc49
Compare
f9bcc49 to
de056d5
Compare
|
The build fails with: Any idea @conda-forge/help-c-cpp ? |
4e929b2 to
58faf8d
Compare
aec2bdd to
f1849c9
Compare
|
Now failing with |
|
This is amazing that you are helping to package this @davidbrochart, thanks so much! For the Any reason not to go straight to latest 1.8.2 version? I also maintain a patch for Windows to build libadwaita without AppStream support since AppStream uses features that aren't compatible with MSVC. It could always be a follow-up PR, but it would be amazing if this recipe supported Linux, macOS, and Windows. |
Are you sure? |
|
Hey @davidbrochart, I noticed in the build log: libadwaita does depend on this for style sheets, I think you need libsass as a build requirement. I can also try to build this locally and help troubleshoot. |
|
Thanks @danyeaw, I tried but https://github.com/conda-forge/libsass-feedstock is actually a Python binding of the libsass C/C++ library. |
|
Hi @davidbrochart, I just remembered that I also had a PR #30909 that was also trying to add libadwaita. I looked more at this and you are absolutely right about libsass being Python bindings. It looks like we'll need sassc and also libsass-lib (or libsass-native) whatever we want to call the actual libsass. |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).