Skip to content

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Oct 6, 2025

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@emasab emasab requested review from MSeal and a team as code owners October 6, 2025 13:25
@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 13:25
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the confluent-kafka-python version from 2.12.0b1 to 2.12.0rc2 and updates the minimum required librdkafka version from 2.11.1 to 2.12.0.

  • Updates version strings and constants for the 2.12.0rc2 release candidate
  • Bumps minimum librdkafka dependency to v2.12.0
  • Updates test configurations and Docker environments to use the new librdkafka version

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/confluent_kafka/src/confluent_kafka.h Updates version string to 2.12.0rc2 and minimum librdkafka version requirement
tests/soak/setup_all_versions.py Updates Python version in test configuration from 2.11.0 to 2.11.1
examples/docker/Dockerfile.alpine Updates librdkafka version environment variable to v2.12.0-RC2
CHANGELOG.md Adds release notes for v2.12.0 with librdkafka dependency information
.semaphore/semaphore.yml Updates CI environment to use librdkafka v2.12.0-RC2

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

* defines and strings in sync.
*/
#define MIN_RD_KAFKA_VERSION 0x020b01ff
#define MIN_RD_KAFKA_VERSION 0x020c00ff
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hexadecimal version value 0x020c00ff appears to represent version 2.12.0.255, but librdkafka v2.12.0-RC2 would typically have a different version encoding. Verify this hex value correctly represents v2.12.0-RC2 or if it should be adjusted for the release candidate.

Suggested change
#define MIN_RD_KAFKA_VERSION 0x020c00ff
#define MIN_RD_KAFKA_VERSION 0x020c0002

Copilot uses AI. Check for mistakes.

COPY . /usr/src/confluent-kafka-python

ENV LIBRDKAFKA_VERSION="v2.11.1"
ENV LIBRDKAFKA_VERSION="v2.12.0-RC2"
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The librdkafka version format 'v2.12.0-RC2' may not match the actual git tag or release naming convention used by librdkafka. Verify that this exact version string exists in the librdkafka repository.

Suggested change
ENV LIBRDKAFKA_VERSION="v2.12.0-RC2"
ENV LIBRDKAFKA_VERSION="v2.12.0"

Copilot uses AI. Check for mistakes.

Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add version information to

  • pyproject.toml
  • docs/conf.py

CHANGELOG.md Outdated
@@ -1,7 +1,9 @@
# Confluent Python Client for Apache Kafka - CHANGELOG

## Unreleased
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this later in the final version.

CHANGELOG.md Outdated

### Added

- AsyncIO Producer (experimental): Introduces `confluent_kafka.aio.AIOProducer` for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add GA for KIP-848 as well. Let's do that in the final version as well.

PYTHON_VERSIONS = [
# '2.12.0',
'2.11.0',
'2.11.1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update RELEASE.md with the information to update version here as well.

@sonarqube-confluent

This comment has been minimized.

Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

@MSeal
Copy link
Contributor

MSeal commented Oct 6, 2025

From comments today, let's get the AIO change moved to an experiemental module / docs updated for the RC release. I'll get that PR up today

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

@emasab emasab enabled auto-merge (squash) October 7, 2025 07:03
@emasab
Copy link
Contributor Author

emasab commented Oct 7, 2025

@MSeal yes we're first merging this PR to finish the librdkafka release validation then you can create a new RC, together we validate it, and lastly the final Python client release.

@sonarqube-confluent

This comment has been minimized.

Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!.

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_2.12.0rc2 branch 3 times, most recently from 3f9bcce to 4be0cda Compare October 7, 2025 13:57
@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emasab emasab merged commit 48ad122 into master Oct 8, 2025
2 checks passed
@emasab emasab deleted the dev_2.12.0rc2 branch October 8, 2025 11:13
@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (66.90% Estimated after merge)
  • Duplications No duplication information (4.90% Estimated after merge)

Project ID: confluent-kafka-python

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants