-
Notifications
You must be signed in to change notification settings - Fork 935
2.12.0rc2 #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.12.0rc2 #2086
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the confluent-kafka-python version from 2.12.0b1 to 2.12.0rc2 and updates the minimum required librdkafka version from 2.11.1 to 2.12.0.
- Updates version strings and constants for the 2.12.0rc2 release candidate
- Bumps minimum librdkafka dependency to v2.12.0
- Updates test configurations and Docker environments to use the new librdkafka version
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/confluent_kafka/src/confluent_kafka.h | Updates version string to 2.12.0rc2 and minimum librdkafka version requirement |
tests/soak/setup_all_versions.py | Updates Python version in test configuration from 2.11.0 to 2.11.1 |
examples/docker/Dockerfile.alpine | Updates librdkafka version environment variable to v2.12.0-RC2 |
CHANGELOG.md | Adds release notes for v2.12.0 with librdkafka dependency information |
.semaphore/semaphore.yml | Updates CI environment to use librdkafka v2.12.0-RC2 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* defines and strings in sync. | ||
*/ | ||
#define MIN_RD_KAFKA_VERSION 0x020b01ff | ||
#define MIN_RD_KAFKA_VERSION 0x020c00ff |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hexadecimal version value 0x020c00ff appears to represent version 2.12.0.255, but librdkafka v2.12.0-RC2 would typically have a different version encoding. Verify this hex value correctly represents v2.12.0-RC2 or if it should be adjusted for the release candidate.
#define MIN_RD_KAFKA_VERSION 0x020c00ff | |
#define MIN_RD_KAFKA_VERSION 0x020c0002 |
Copilot uses AI. Check for mistakes.
COPY . /usr/src/confluent-kafka-python | ||
|
||
ENV LIBRDKAFKA_VERSION="v2.11.1" | ||
ENV LIBRDKAFKA_VERSION="v2.12.0-RC2" |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The librdkafka version format 'v2.12.0-RC2' may not match the actual git tag or release naming convention used by librdkafka. Verify that this exact version string exists in the librdkafka repository.
ENV LIBRDKAFKA_VERSION="v2.12.0-RC2" | |
ENV LIBRDKAFKA_VERSION="v2.12.0" |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add version information to
- pyproject.toml
- docs/conf.py
CHANGELOG.md
Outdated
@@ -1,7 +1,9 @@ | |||
# Confluent Python Client for Apache Kafka - CHANGELOG | |||
|
|||
## Unreleased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this later in the final version.
CHANGELOG.md
Outdated
|
||
### Added | ||
|
||
- AsyncIO Producer (experimental): Introduces `confluent_kafka.aio.AIOProducer` for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add GA for KIP-848 as well. Let's do that in the final version as well.
PYTHON_VERSIONS = [ | ||
# '2.12.0', | ||
'2.11.0', | ||
'2.11.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update RELEASE.md with the information to update version here as well.
This comment has been minimized.
This comment has been minimized.
131e86f
to
f1134dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
From comments today, let's get the AIO change moved to an experiemental module / docs updated for the RC release. I'll get that PR up today |
This comment has been minimized.
This comment has been minimized.
f1134dc
to
16c447a
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
16c447a
to
23fc8f2
Compare
@MSeal yes we're first merging this PR to finish the librdkafka release validation then you can create a new RC, together we validate it, and lastly the final Python client release. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!.
3f9bcce
to
4be0cda
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
4be0cda
to
a0d3311
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups