-
Notifications
You must be signed in to change notification settings - Fork 935
2.12.0rc2 #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.12.0rc2 #2086
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -38,27 +38,27 @@ | |||||
/** | ||||||
* @brief confluent-kafka-python version, must match that of pyproject.toml. | ||||||
*/ | ||||||
#define CFL_VERSION_STR "2.12.0b1" | ||||||
#define CFL_VERSION_STR "2.12.0rc2" | ||||||
|
||||||
/** | ||||||
* Minimum required librdkafka version. This is checked both during | ||||||
* build-time (just below) and runtime (see confluent_kafka.c). | ||||||
* Make sure to keep the MIN_RD_KAFKA_VERSION, MIN_VER_ERRSTR and #error | ||||||
* defines and strings in sync. | ||||||
*/ | ||||||
#define MIN_RD_KAFKA_VERSION 0x020b01ff | ||||||
#define MIN_RD_KAFKA_VERSION 0x020c00ff | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The hexadecimal version value 0x020c00ff appears to represent version 2.12.0.255, but librdkafka v2.12.0-RC2 would typically have a different version encoding. Verify this hex value correctly represents v2.12.0-RC2 or if it should be adjusted for the release candidate.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
|
||||||
#ifdef __APPLE__ | ||||||
#define MIN_VER_ERRSTR "confluent-kafka-python requires librdkafka v2.11.1 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`" | ||||||
#define MIN_VER_ERRSTR "confluent-kafka-python requires librdkafka v2.12.0 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`" | ||||||
#else | ||||||
#define MIN_VER_ERRSTR "confluent-kafka-python requires librdkafka v2.11.1 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html" | ||||||
#define MIN_VER_ERRSTR "confluent-kafka-python requires librdkafka v2.12.0 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html" | ||||||
#endif | ||||||
|
||||||
#if RD_KAFKA_VERSION < MIN_RD_KAFKA_VERSION | ||||||
#ifdef __APPLE__ | ||||||
#error "confluent-kafka-python requires librdkafka v2.11.1 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`" | ||||||
#error "confluent-kafka-python requires librdkafka v2.12.0 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`" | ||||||
#else | ||||||
#error "confluent-kafka-python requires librdkafka v2.11.1 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html" | ||||||
#error "confluent-kafka-python requires librdkafka v2.12.0 or later. Install the latest version of librdkafka from the Confluent repositories, see http://docs.confluent.io/current/installation.html" | ||||||
#endif | ||||||
#endif | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ | |
|
||
PYTHON_VERSIONS = [ | ||
# '2.12.0', | ||
'2.11.0', | ||
'2.11.1', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update RELEASE.md with the information to update version here as well. |
||
'2.10.1', | ||
'2.8.0', | ||
'2.6.1', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The librdkafka version format 'v2.12.0-RC2' may not match the actual git tag or release naming convention used by librdkafka. Verify that this exact version string exists in the librdkafka repository.
Copilot uses AI. Check for mistakes.