fix: config loading set to false before being fetched #7994
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
tingwai
requested changes
Sep 26, 2025
| const buttonPadding = isSidebar ? "px-2 py-1.5" : "px-0 py-0.5"; | ||
| const buttonStyle = isSidebar ? {} : { fontSize: fontSize(-3) }; | ||
|
|
||
| console.log("debug1 config loading", configLoading); |
There was a problem hiding this comment.
PR LGTM, can you remove this first?
There was a problem hiding this comment.
Oh just saw you'll be out, I can remove it
tingwai
approved these changes
Sep 26, 2025
RomneyDa
requested changes
Sep 26, 2025
There was a problem hiding this comment.
@uinstinct I'm wondering if this will lead to infinite loading for local folks or folks with e.g. an error in their yaml schema. Why is the method for detecting config not yet loaded to check configLoadInterrupted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not set config loading to false before config from hub is fetched.
In case of local config, config is already loaded in core before gui initializes (due to the constructor call).
In case of profile config, config takes time to load (due to data fetching from remote server) and profileId is not yet set.
resolves CON-3946
AI Code Review
@continue-general-reviewor@continue-detailed-reviewChecklist
Screen recording or screenshot
before.mp4
after.mp4
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Fixes premature clearing of the config loading state when fetching config from the hub. The UI now stays in “Loading” until remote profile config is ready, preventing the empty-state flash and addressing CON-3946.