Skip to content

fix: config loading set to false before being fetched #7994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: config loading set to false before being fetched #7994

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c40b6bc
fix: config loading set to false before being fetched
uinstinct Sep 26, 2025
027a95c
remove console log
tingwai Sep 26, 2025
5292eeb
Merge branch 'main' into config-loading-hub
uinstinct Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions gui/src/components/AssistantAndOrgListbox/SelectedAssistantButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ export function SelectedAssistantButton({
const buttonPadding = isSidebar ? "px-2 py-1.5" : "px-0 py-0.5";
const buttonStyle = isSidebar ? {} : { fontSize: fontSize(-3) };

console.log("debug1 config loading", configLoading);

return (
<ListboxButton
data-testid="assistant-select-button"
Expand All @@ -33,9 +35,7 @@ export function SelectedAssistantButton({
className={`flex flex-row items-center ${isSidebar ? "w-full justify-between" : "gap-1.5"}`}
>
<div className="flex min-w-0 flex-1 flex-row items-center gap-2">
{selectedProfile === null ? (
"Create your first agent"
) : configLoading ? (
{configLoading ? (
<span className="text-description flex flex-row items-center">
<ArrowPathIcon
className={cn(
Expand All @@ -45,6 +45,8 @@ export function SelectedAssistantButton({
/>
Loading
</span>
) : selectedProfile === null ? (
"Create your first agent"
) : (
<>
<AssistantIcon assistant={selectedProfile} size={iconSize} />
Expand Down
9 changes: 9 additions & 0 deletions gui/src/hooks/ParallelListeners.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,15 @@ function ParallelListeners() {
);
if (result.status === "success") {
await handleConfigUpdate(true, result.content);

// (hub) config has not yet loaded - will be updated via configUpdate
if (
result.content.profileId === null &&
result.content.result.configLoadInterrupted
) {
dispatch(setConfigLoading(true));
return;
}
}
dispatch(setConfigLoading(false));
}
Expand Down
Loading