vine: check whether hash table key is present before inserting #4309
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btovar
requested changes
Jan 6, 2026
Member
btovar
left a comment
btovar
left a comment
There was a problem hiding this comment.
This issue may occur in several places in the code. Instead let's only print the notice if the new pointer is different from the old one.
Member
Author
|
I see, does the new change look like a solution? |
btovar
approved these changes
Jan 6, 2026
Member
|
Looks good! Ready to merge? |
Member
Author
|
RTM |
btovar
pushed a commit
that referenced
this pull request
Jan 6, 2026
* vine: check whether hash table key is present before inserting * check duplicate key when inserting --------- Co-authored-by: Jin Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For #4308
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.