Skip to content

vine: check whether hash table key is present before inserting #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btovar merged 4 commits into from
Jan 6, 2026
Merged

vine: check whether hash table key is present before inserting #4309

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b0cdf1
vine: check whether hash table key is present before inserting
Jan 6, 2026
f0c10b6
Merge branch 'cooperative-computing-lab:master' into duplicate-key-in…
JinZhou5042 Jan 6, 2026
843d8ed
check duplicate key when inserting
Jan 6, 2026
6d69e93
Merge branch 'duplicate-key-insertion' of github.com:JinZhou5042/ccto…
Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions dttools/src/hash_table.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,15 @@ static int hash_table_reduce_buckets(struct hash_table *h)

int hash_table_insert(struct hash_table *h, const char *key, const void *value)
{
/* Return 0 if the key already exists. */
void *old_value = hash_table_lookup(h, key);
if (old_value) {
if (old_value != value) {
notice(D_DEBUG, "key %s already exists in hash table with different value, ignoring new value.", key);
}
return 0;
}

if (((float)h->size / h->bucket_count) > DEFAULT_MAX_LOAD)
hash_table_double_buckets(h);

Expand All @@ -274,8 +283,8 @@ int hash_table_insert(struct hash_table *h, const char *key, const void *value)
* key would be included or skipped in the iteration */
h->cant_iterate_yet = 1;
} else {
/* Key already exists, free the unused entry */
notice(D_DEBUG, "key % already exists in hash table, ignoring new value.", key);
/* Should be unreachable but keep for safety. */
notice(D_ERROR, "Failed to insert key %s into hash table.", key);
free(e->key);
free(e);
}
Expand Down