CBG-1423: Enable GSI by default for integration tests #7939
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Changes the default behavior of integration tests to enable GSI (Global Secondary Index) by default, reversing the previous configuration where GSI was disabled by default. This aligns the test environment more closely with production deployments where GSI is typically enabled.
Key Changes
- Modified the default value of
useGSIfromfalsetotruein the test utility function - Updated the corresponding comment to reflect the new default behavior
|
|
||
| // Default to disabling GSI, but allow with SG_TEST_USE_GSI=true | ||
| useGSI := false | ||
| // Default to enable GSI, but disable with SG_TEST_USE_GSI=false |
There was a problem hiding this comment.
The comment references the environment variable as 'SG_TEST_USE_GSI', but line 280 shows the actual variable name is 'TestEnvSyncGatewayDisableGSI'. The comment should accurately reflect the environment variable name used in the code.
Suggested change
| // Default to enable GSI, but disable with SG_TEST_USE_GSI=false | |
| // Default to enabling GSI, but allow disabling via the TestEnvSyncGatewayDisableGSI env var. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-1423
Describe your PR here...
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGatewayIntegration/210/