Skip to content

CBG-1423: Enable GSI by default for integration tests #7939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RIT3shSapata wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

CBG-1423: Enable GSI by default for integration tests #7939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions base/util_testing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,8 @@ func TestsDisableGSI() bool {
return true
}

// Default to disabling GSI, but allow with SG_TEST_USE_GSI=true
useGSI := false
// Default to enable GSI, but disable with SG_TEST_USE_GSI=false
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment references the environment variable as 'SG_TEST_USE_GSI', but line 280 shows the actual variable name is 'TestEnvSyncGatewayDisableGSI'. The comment should accurately reflect the environment variable name used in the code.

Suggested change
// Default to enable GSI, but disable with SG_TEST_USE_GSI=false
// Default to enabling GSI, but allow disabling via the TestEnvSyncGatewayDisableGSI env var.

Copilot uses AI. Check for mistakes.
useGSI := true
if envUseGSI := os.Getenv(TestEnvSyncGatewayDisableGSI); envUseGSI != "" {
useGSI, _ = strconv.ParseBool(envUseGSI)
}
Expand Down