Enable async loads of Scenes #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't expose `Glfw::Window` through engine; users should not be able to access `Glfw` directly. - Return entire state in `Engine::poll()` instead of just delta time.
Takes an optional `on_done` callback; loaded scene swapped and callback invoked on poll thread (during `poll()`). TODO: solve progress notification across the threads.
Algorithm for deferring existing requests is buggy: get random malloc "unaligned fastbin chunk detected" crashes, attempts to root cause have been unsuccessful. Winding back to storing a single request and denying subsequent ones until the stored one is idle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #44