1617: fix(engine): correct operator precedence in validateTerminology… #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Requirements
The if condition in validateTerminologyRequirements was incorrectly
evaluating due to missing parentheses. Because `&&` has higher
precedence than `||`, the expression:
(A || B || C && D)
was being evaluated as:
(A || B || (C && D))
instead of the intended:
((A || B || C) && D)
This caused terminology requirements to be bypassed in some cases
when a TerminologyProvider was not configured.
Fix: Add explicit parentheses so the check correctly enforces that
any terminology usage requires a TerminologyProvider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1617: The if condition in validateTerminologyRequirements was incorrectly evaluating due to missing parentheses. Because '&&' has higher precedence than '||', the expression:
(A || B || C && D)was being evaluated as:
(A || B || (C && D))instead of the intended:
((A || B || C) && D)This caused terminology requirements to throw an exception in cases when a TerminologyProvider was configured with a library with ValueSets.
Fix: Add explicit parentheses so the check correctly validates as intended.