Skip to content

1617: fix(engine): correct operator precedence in validateTerminology… #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amondel2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

1617: fix(engine): correct operator precedence in validateTerminology… #1618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Src/java/engine/src/main/java/org/opencds/cqf/cql/engine/execution/CqlEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,15 +499,17 @@ private void validateDataRequirements(Library library) {
private void validateTerminologyRequirements(Library library) {
// TODO: Smarter validation would be to checkout and see if any retrieves
// Use terminology, and to check for any codesystem lookups.
if ((library.getCodeSystems() != null
// Please remember that (true) || (true) || (true) && false == true beacause of order of operations, so the
// extra () are needed!
if (((library.getCodeSystems() != null
&& library.getCodeSystems().getDef() != null
&& !library.getCodeSystems().getDef().isEmpty())
|| (library.getCodes() != null
&& library.getCodes().getDef() != null
&& !library.getCodes().getDef().isEmpty())
|| (library.getValueSets() != null
&& library.getValueSets().getDef() != null
&& !library.getValueSets().getDef().isEmpty())
&& !library.getValueSets().getDef().isEmpty()))
&& this.environment.getTerminologyProvider() == null) {
throw new IllegalArgumentException(String.format(
"Library %s has terminology requirements and no terminology provider is registered.",
Expand Down