-
Notifications
You must be signed in to change notification settings - Fork 0
Cw2-18 Improve Semantic HTML #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* added events template * removed section * modified events to coordinate with navbar on click --------- Co-authored-by: Stuart Cutbush <[email protected]> Co-authored-by: Derek Xu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, not too complicated.
Just make sure the pipeline is passing, will only take a second, you can run npm run lint:fix
for example for automatic linting
…soc/csesoc-website-2023 into CW2-18_Improve_Semantic_HTML
Alrighty, should work now, prettier just wanted the code formatted :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* changed the h1 tags * changed image alt tags * changed tailwind * CW2-3 Add events section (#4) * added events template * removed section * modified events to coordinate with navbar on click --------- Co-authored-by: Stuart Cutbush <[email protected]> Co-authored-by: Derek Xu <[email protected]> * changes to make linter approve * formatted code? --------- Co-authored-by: Stuart Cutbush <[email protected]> Co-authored-by: Derek Xu <[email protected]>
Why the changes are required?
For SEO & Accessibility
Changes
Screenshots
No UI changes
Comments
No comments