Skip to content

Cw2-18 Improve Semantic HTML #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Conversation

QuadAces
Copy link
Contributor

Why the changes are required?

For SEO & Accessibility

Changes

  • Made it so that the site only has one h1 tag for SEO
  • Made it so that images/icons have an alt tag for accessibility

Screenshots

No UI changes

Comments

No comments

@QuadAces QuadAces changed the title Cw2 18 Improve Semantic HTML Cw2-18 Improve Semantic HTML Apr 11, 2024
* added events template

* removed section

* modified events to coordinate with navbar on click

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>
Copy link
Contributor

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, not too complicated.

Just make sure the pipeline is passing, will only take a second, you can run npm run lint:fix for example for automatic linting

@QuadAces
Copy link
Contributor Author

Alrighty, should work now, prettier just wanted the code formatted :P

@QuadAces QuadAces requested a review from derekxu04 April 17, 2024 09:35
Copy link
Contributor

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@derekxu04 derekxu04 merged commit 229c00e into master Apr 18, 2024
1 check passed
@derekxu04 derekxu04 deleted the CW2-18_Improve_Semantic_HTML branch April 18, 2024 07:21
PenTest-duck pushed a commit that referenced this pull request May 30, 2024
* changed the h1 tags

* changed image alt tags

* changed tailwind

* CW2-3 Add events section (#4)

* added events template

* removed section

* modified events to coordinate with navbar on click

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>

* changes to make linter approve

* formatted code?

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants