-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): create modularized libraries #113
Changes from all commits
b04111b
c23c0ec
f336dde
d9a2cc1
dff14a5
f568042
ba3cf15
5e884c0
d61da75
c29f3e5
d312e10
12cff16
2c896da
351cb48
a7a0288
9f5c189
1a75c1d
c7b2fd1
2e618be
3a9d0f7
151eb9e
2a3badb
26743aa
f9e10b4
8703891
a02ed39
b626b8f
404655d
c3029eb
7b960e6
c396966
501d69e
8d1503a
beeda9d
b207a1e
e8f761e
e623f0a
4466a71
9f179b8
c39537d
93b1a93
fa9fa86
26481bf
c8325aa
b51132f
b1522f5
c48c3bb
f36968f
fd6fbb4
75b33bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,3 +45,8 @@ Thumbs.db | |
# Next.js | ||
.next | ||
out | ||
|
||
# Environment variables files | ||
**/*.env | ||
**/*.env.* | ||
!**/*.env.example |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# path to a directory with all packages | ||
storage: ../tmp/local-registry/storage | ||
|
||
# a list of other known repositories we can talk to | ||
uplinks: | ||
npmjs: | ||
url: https://registry.npmjs.org/ | ||
maxage: 60m | ||
|
||
packages: | ||
'**': | ||
# give all users (including non-authenticated users) full access | ||
# because it is a local registry | ||
access: $all | ||
publish: $all | ||
unpublish: $all | ||
|
||
# if package is not available locally, proxy requests to npm registry | ||
proxy: npmjs | ||
|
||
# log settings | ||
logs: | ||
type: stdout | ||
format: pretty | ||
level: warn | ||
|
||
publish: | ||
allow_offline: true # set offline to true to allow publish offline |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,8 @@ import { createElement } from 'react' | |
import { | ||
GitPullRequestCreateArrow as ContributionGuidelinesIcon, | ||
Dock as HomeIcon, | ||
Library as KnowledgeBaseIcon, | ||
BookOpenText as KnowledgeBaseIcon, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification KnowledgeBaseIcon usage not updated in pages array The import for 🔗 Analysis chainVerify KnowledgeBaseIcon usage in pages array The import for Please run the following script to verify that the If the script doesn't return any results, please update the 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify KnowledgeBaseIcon usage in pages array
# Test: Search for KnowledgeBaseIcon usage in the file
rg --type typescript 'icon:\s*KnowledgeBaseIcon' apps/docs/src/app/docs/source.ts
Length of output: 118 Script: #!/bin/bash
# Description: Verify KnowledgeBaseIcon usage in pages array
# Search for KnowledgeBaseIcon usage in the pages array within source.ts
rg 'icon:\s*KnowledgeBaseIcon' apps/docs/src/app/docs/source.ts
Length of output: 94 |
||
Library as LibrariesIcon, | ||
Layers as ToolsIcon, | ||
icons, | ||
} from 'lucide-react' | ||
|
@@ -36,6 +37,12 @@ export const pages = [ | |
url: 'knowledge-base', | ||
icon: KnowledgeBaseIcon, | ||
}, | ||
{ | ||
title: 'Libraries', | ||
description: 'Libraries within this monorepo used within the applications.', | ||
url: 'libraries', | ||
icon: LibrariesIcon, | ||
}, | ||
] | ||
|
||
export const { getPage, getPages, pageTree } = loader({ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider using an absolute path for storage
The current storage path is relative (
../tmp/local-registry/storage
). This could lead to issues if the working directory changes. Additionally, using a temporary directory for storage might result in data loss.Consider the following improvements:
Example: