Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add run mode skip to cylc show #6554

Merged
merged 16 commits into from
Mar 11, 2025
Merged

Add run mode skip to cylc show #6554

merged 16 commits into from
Mar 11, 2025

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 13, 2025 •
edited by MetRonnie
Loading

Note

schema change Change to the Cylc GraphQL schema - changed TaskRunMode to include simulation and dummy modes

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • Very, very small feature.

@wxtim wxtim force-pushed the feat.skip_shown_in_cylc_show branch from 04bd7b1 to b01e496 Compare January 13, 2025 15:37
@wxtim wxtim changed the base branch from master to 8.4.x January 13, 2025 15:37
@wxtim wxtim self-assigned this Jan 13, 2025
@wxtim wxtim added the could be better Not exactly a bug, but not ideal. label Jan 13, 2025
oliver-sanders
oliver-sanders reviewed Jan 13, 2025
View reviewed changes
@MetRonnie MetRonnie marked this pull request as draft January 13, 2025 16:07
@wxtim wxtim requested a review from oliver-sanders January 15, 2025 11:54
@wxtim wxtim marked this pull request as ready for review January 15, 2025 11:54
@wxtim wxtim force-pushed the feat.skip_shown_in_cylc_show branch from bfa3254 to 71e3f59 Compare January 16, 2025 11:25
oliver-sanders
oliver-sanders reviewed Jan 16, 2025
View reviewed changes
@wxtim wxtim force-pushed the feat.skip_shown_in_cylc_show branch from 9c2f350 to 060a20a Compare January 17, 2025 08:17
@wxtim wxtim requested a review from oliver-sanders January 17, 2025 08:17
@wxtim wxtim marked this pull request as draft January 21, 2025 08:45
MetRonnie
MetRonnie reviewed Jan 21, 2025
View reviewed changes
wxtim and others added 4 commits January 22, 2025 10:14
@wxtim
add run mode skip to cylc show
147020a
@wxtim
test changing task mode with broadcast
818efc0 
broaden the definition of task-mode

Save workflow states to the runtime config object.
@wxtim
fixed a broken test
7c626a3 
fixed TUI test

fix a broken functional test
@wxtim @oliver-sanders
Apply suggestions from code review
4ca26a0 
Co-authored-by: Oliver Sanders <[email protected]>
@wxtim wxtim force-pushed the feat.skip_shown_in_cylc_show branch from 16640a8 to 4ca26a0 Compare January 22, 2025 13:44
@wxtim wxtim changed the base branch from 8.4.x to master January 22, 2025 13:44
@MetRonnie MetRonnie added this to the 8.5.0 milestone Jan 22, 2025
@MetRonnie MetRonnie added the schema change Change to the Cylc GraphQL schema label Jan 22, 2025
@wxtim wxtim marked this pull request as ready for review January 23, 2025 09:02
wxtim and others added 2 commits January 24, 2025 09:15
@MetRonnie MetRonnie mentioned this pull request Feb 17, 2025
Open
6 tasks
@MetRonnie
Copy link
Member

MetRonnie commented Feb 17, 2025 •
edited
Loading

UI accompaniment: cylc/cylc-ui#2057

MetRonnie
MetRonnie approved these changes Feb 18, 2025
View reviewed changes
@wxtim

This comment was marked as resolved.

Sign in to view
@wxtim
Merge remote-tracking branch 'upstream/master' into feat.skip_shown_i…
1d836ec 
…n_cylc_show

* upstream/master: (27 commits)
  tui: open log files in external application (cylc#6611)
  fix typo in stop.py - options.max_poll -> options.max_polls
  schema: add first-parent descendants (cylc#6610)
  doc: improve NamespaceIDGlob description (cylc#6637)
  Document that "ex" prefix means "exclude" [skip ci]
  tests: remove string templating in SQL statements (cylc#6631)
  Merge pull request cylc#6629 from wxtim/tests.flake8
  Remove vestiges of authorisation layer removed in cylc#3845
  Bump dev version
  Prepare release 8.4.1
  Merge pull request cylc#6578 from MetRonnie/graphql-err-handling
  Add test
  Update cylc/flow/etc/examples/expiry/index.rst
  Correct type annotations
  Fix duplicate task triggers
  Add test for duplicate task triggers
  Pytest: full verbosity for assertions
  Fix test picking up user global config
  Wrapper script: fix `PATH` override preventing selection of Cylc version in GUI under Cylc Hub
  Get poll to return task failure if job/log has been removed. (cylc#6577)
  ...
@oliver-sanders

This comment was marked as resolved.

Sign in to view
@oliver-sanders oliver-sanders mentioned this pull request Mar 11, 2025
Open
8 tasks
@oliver-sanders oliver-sanders merged commit 7432db1 into cylc:master Mar 11, 2025
27 checks passed
@oliver-sanders oliver-sanders mentioned this pull request Mar 11, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@wxtim wxtim

Labels
could be better Not exactly a bug, but not ideal. schema change Change to the Cylc GraphQL schema
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @MetRonnie @oliver-sanders