ci: update workflow main.yml to node20 / Node.js 22 #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add event trigger for pull_request to master branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
The GitHub Actions workflow .github/workflows/main.yml is outdated, relying on Node.js 16 that entered end-of-life status on Sep 11, 2023.
node16node16node-version: 16as a parameter installs Node.js16.xThe workflow triggers on
pushand does not usepull_request. This may miss issues if there is a delay between pushing to a branch and creating a PR, and there are environmental changes like a new Node.js release in the interim.The CI result should also be visible in any PR. This requires setting the
pull_requestevent trigger.Change
masterbranch.Update to:
node20usagenode20usagenode-version: 22using the Node.js Active LTS version