-
Notifications
You must be signed in to change notification settings - Fork 3.4k
refactor: use rollup to build the cli package #33235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cacieprins
wants to merge
44
commits into
develop
Choose a base branch
from
refactor-cli-rollup
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+654
−270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
refactor-cli-rollup
|
| Run status |
|
| Run duration | 19m 37s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
14
|
|
|
1104
|
|
|
4
|
|
|
26982
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.18%
|
|
|---|---|
|
|
194
|
|
|
164
|
Accessibility
97.94%
|
|
|---|---|
|
|
4 critical
8 serious
3 moderate
2 minor
|
|
|
102
|
33ba7b9 to
604aefb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
When using pure
tscto build the cli package, we are unable to include other packages from the monorepo without quite a bit of hassle. Migrating to rollup for the cli build process enables bundling monorepo packages up with the cli, reducing the need for custom scripting.This PR also edits the pre/post build scripts for clarity. They're named after what they do, and are included in the proper package.json hook scripts to describe when they're executed.
Note
Build & Packaging
rollup.config.mjs, bundlestslib, externalizes node_modules, and preserveslib/*structure indist/package.jsonscripts (prebuild/postbuild,build(-cli)) and dev deps; adds./binexport mapping; introducesclean-cli-buildand postbuild steps to prepbuild/Runtime & API Refactors
lib/cypress.tsandlib/exec/xvfb.tsto named exports;lib/index.tsre-exports named APIs and keeps default export for CJS compatibilitylib/bin/cypress.ts) to bootstrap via../clirelative-to-repo-roothelper; updatesexec/spawn.tsandtasks/verify.tsto resolvescripts/start.jsfrom repo root in dev modeTests & Config
knip.json; minor.gitignorefix; refreshesyarn.lockWritten by Cursor Bugbot for commit 5c59239. This will update automatically on new commits. Configure here.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?