Skip to content

Conversation

@cacieprins
Copy link
Contributor

@cacieprins cacieprins commented Jan 13, 2026

  • Closes

Additional details

When using pure tsc to build the cli package, we are unable to include other packages from the monorepo without quite a bit of hassle. Migrating to rollup for the cli build process enables bundling monorepo packages up with the cli, reducing the need for custom scripting.

This PR also edits the pre/post build scripts for clarity. They're named after what they do, and are included in the proper package.json hook scripts to describe when they're executed.


Note

Build & Packaging

  • Switches CLI build to Rollup with CJS/ESM outputs; adds rollup.config.mjs, bundles tslib, externalizes node_modules, and preserves lib/* structure in dist/
  • Updates package.json scripts (prebuild/postbuild, build(-cli)) and dev deps; adds ./bin export mapping; introduces clean-cli-build and postbuild steps to prep build/
  • Adds scripts for build prep and bundling CT frameworks; removes legacy scripts; extensive README updates explaining new flow

Runtime & API Refactors

  • Refactors lib/cypress.ts and lib/exec/xvfb.ts to named exports; lib/index.ts re-exports named APIs and keeps default export for CJS compatibility
  • Changes CLI binary entry (lib/bin/cypress.ts) to bootstrap via ../cli
  • Introduces relative-to-repo-root helper; updates exec/spawn.ts and tasks/verify.ts to resolve scripts/start.js from repo root in dev mode

Tests & Config

  • Updates unit tests to new module shapes and dev path resolution; adjusts expectations for spawn args
  • Adds entries to knip.json; minor .gitignore fix; refreshes yarn.lock

Written by Cursor Bugbot for commit 5c59239. This will update automatically on new commits. Configure here.

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins self-assigned this Jan 13, 2026
@cypress
Copy link

cypress bot commented Jan 13, 2026

cypress    Run #68617

Run Properties:  status check passed Passed #68617  •  git commit 5c59239c55: add entrypoints to cli knip config
Project cypress
Branch Review refactor-cli-rollup
Run status status check passed Passed #68617
Run duration 19m 37s
Commit git commit 5c59239c55: add entrypoints to cli knip config
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 14
Tests that did not run due to a developer annotating a test with .skip  Pending 1104
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26982
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.18%
  Untested elements 194  
  Tested elements 164  
Accessibility  97.94%
  Failed rules  4 critical   8 serious   3 moderate   2 minor
  Failed elements 102  

@cacieprins cacieprins marked this pull request as ready for review January 15, 2026 15:56
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants