-
Notifications
You must be signed in to change notification settings - Fork 3.4k
refactor: use rollup to build the cli package #33235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cacieprins
wants to merge
44
commits into
develop
Choose a base branch
from
refactor-cli-rollup
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+654
−270
Open
Changes from 41 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
f5c9610
move to rollup
cacieprins d445a7c
no longer need to move some subdirs in start-build, special bin dir h…
cacieprins b7de399
Merge branch 'develop' into refactor-cli-rollup
cacieprins 1950dd5
preserve modules so __dirname is properly resolved in spawn.ts
cacieprins cdb35ac
ensure lib/exec/xvfb exports default
cacieprins fa75f41
make build processes more intuitive
cacieprins 1424659
additional
cacieprins 513ef75
and
cacieprins 157f780
fix clean
cacieprins e9b35c3
fix tests
cacieprins a8dcefb
revert
cacieprins 3401af4
rename clean cmd
cacieprins d7965dd
fix cjs exports
cacieprins d6c80d8
fix test import
cacieprins 7cbb83f
fix tertiary dep bundling
cacieprins aa86fd6
maybe..?
cacieprins e40698e
ensure cli is built before tests are run
cacieprins c644984
exports= again
cacieprins dbefeff
discrete exports
cacieprins 5a66643
maybe if tslib is bundled
cacieprins 645fb6e
add tslib as dependency for rollup
cacieprins 1fe7edf
lockfile, no longer bundle
cacieprins b2a42ef
bundle tslib?
cacieprins 0c4c1f5
cache
cacieprins cc93887
preserve entry file paths in dist dir
cacieprins dc9f262
relative path change
cacieprins 5994305
ensure the cjs entrypoint for the esm build of cli is available in dist
cacieprins 15b83ee
properly import json so rollup picks it up
cacieprins 890d30e
ensure bin entrypoint has no file extension
cacieprins 8bb047a
add exec/run.ts ? to entry files
cacieprins f0d6fc8
Revert "add exec/run.ts ? to entry files"
cacieprins 604aefb
simplify rollup; make bin script +x on postbuild
cacieprins 969a34b
Merge branch 'develop' into refactor-cli-rollup
cacieprins 98d9c45
cleanup
cacieprins 7c79b6b
updates build docs
cacieprins cb4034c
fix ./bin export path
cacieprins 86e4932
Merge branch 'develop' into refactor-cli-rollup
cacieprins f63f935
comment to clarify why relative path resolution changed in spawn.ts
cacieprins a14f399
make script start path (for dev mode) less brittle vis a vis build ar…
cacieprins 32543ec
cleanup
cacieprins c34d13b
since we dont need monorepo packages yet, adding it here is premature
cacieprins 64c80a6
externalize package.json to fix install script
cacieprins 9805c44
Merge branch 'develop' into refactor-cli-rollup
cacieprins 5c59239
add entrypoints to cli knip config
cacieprins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,4 +22,4 @@ angular | |
| angular-zoneless | ||
| svelte | ||
| index.js | ||
| lib/**/*.js | ||
| lib/**/*.js | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| #!/usr/bin/env node | ||
| // declared here in order to avoid consumers who are looking for the binary to be available relative to the dist directory | ||
| import '../../bin/cypress' | ||
| import CLI from '../cli' | ||
|
|
||
| CLI.init() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.