Fix misused of inline step options (#254) #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an inline step is used, the ordering of the backoff rate and interval options is incorrect. The newly added test shows the issue. The issue was not happening with an @step.
Contributor
Author
|
I have very little experience with the codebase, so you might want to refactor the test. I quickly reused some of the existing ones to prove the existence of the issue and check it was solved. |
Member
|
Thank you very much @youribonnaffe. Really appreciate the contribution. We will take a look and get back to you |
devhawk
approved these changes
Dec 21, 2025
Collaborator
devhawk
left a comment
devhawk
left a comment
There was a problem hiding this comment.
Looks good. Thanks @youribonnaffe!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an inline step is used, the ordering of the backoff rate and interval options is incorrect.
The newly added test shows the issue. The issue was not happening with an @step.