fix(vi): handle vi default storage class from module config #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardcoretime
force-pushed
the
fix/vi/handle-mc-vi-default-storage-class
branch
from
7c204e6 to
a7fbb78
Compare
hardcoretime
requested review from
Isteb4k,
fl64 and
yaroslavborbat
as code owners
Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
fix/vi/handle-mc-vi-default-storage-class
branch
from
a53757f to
7ea57da
Compare
eofff
requested changes
Apr 4, 2025
| }) | ||
| } | ||
|
|
||
| func IndexVIByNotReadyStorageClass(ctx context.Context, mgr manager.Manager) error { |
Contributor
There was a problem hiding this comment.
Why with this name you indexing by sc ready? And ignore non pvc VI please.
| return nil, err | ||
| } | ||
|
|
||
| if virtualImages, ok := moduleConfig.Spec.Settings["virtualImages"].(map[string]interface{}); ok { |
Contributor
There was a problem hiding this comment.
Do not hardcode please, use constant not string literal (set it if needed), next line too
Contributor
There was a problem hiding this comment.
"virtualImages" var seems like slice of VI, use virtualImagesSetting or something
| var ( | ||
| moduleConfigViDefaultStorageClass string | ||
| moduleConfig mcapi.ModuleConfig | ||
| moduleConfigName = "virtualization" |
| oldViDefaultSc string | ||
| newViDefaultSc string | ||
| ) | ||
| if virtualImages, ok := oldMc.Spec.Settings["virtualImages"].(map[string]interface{}); ok { |
Contributor
There was a problem hiding this comment.
Use consts, not string literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
When a
VirtualImageis created without theStorageClassfield in its specification and the default storage class is absent from theModuleConfig, it is not handled after updating the default storage class in theModuleConfig.What is the expected result?
The default storage class field works properly in the reconciliation loop of the
VirtualImageresource.Checklist
Changelog entries