fix(vi): handle vi default storage class from module config #902
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| /* | ||
| Copyright 2025 Flant JSC | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package watcher | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "log/slog" | ||
|
|
||
| "k8s.io/apimachinery/pkg/fields" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/controller" | ||
| "sigs.k8s.io/controller-runtime/pkg/event" | ||
| "sigs.k8s.io/controller-runtime/pkg/handler" | ||
| "sigs.k8s.io/controller-runtime/pkg/manager" | ||
| "sigs.k8s.io/controller-runtime/pkg/predicate" | ||
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | ||
| "sigs.k8s.io/controller-runtime/pkg/source" | ||
|
|
||
| "github.com/deckhouse/virtualization-controller/pkg/controller/indexer" | ||
| mcapi "github.com/deckhouse/virtualization-controller/pkg/controller/moduleconfig/api" | ||
| virtv2 "github.com/deckhouse/virtualization/api/core/v1alpha2" | ||
| "github.com/deckhouse/virtualization/api/core/v1alpha2/vicondition" | ||
| ) | ||
|
|
||
| type ModuleConfigWatcher struct { | ||
| client client.Client | ||
| logger *slog.Logger | ||
| } | ||
|
|
||
| func NewModuleConfigWatcher(client client.Client) *StorageClassWatcher { | ||
| return &StorageClassWatcher{ | ||
| client: client, | ||
| logger: slog.Default().With("watcher", "moduleconfig"), | ||
| } | ||
| } | ||
|
|
||
| func (w ModuleConfigWatcher) Watch(mgr manager.Manager, ctr controller.Controller) error { | ||
| return ctr.Watch( | ||
| source.Kind(mgr.GetCache(), &mcapi.ModuleConfig{}), | ||
| handler.EnqueueRequestsFromMapFunc(w.enqueueRequests), | ||
| predicate.Funcs{ | ||
| CreateFunc: func(event event.CreateEvent) bool { return true }, | ||
| DeleteFunc: func(event event.DeleteEvent) bool { return true }, | ||
| UpdateFunc: func(event event.UpdateEvent) bool { | ||
| oldMc, oldOk := event.ObjectOld.(*mcapi.ModuleConfig) | ||
| newMc, newOk := event.ObjectNew.(*mcapi.ModuleConfig) | ||
| if !oldOk || !newOk { | ||
| return false | ||
| } | ||
| var ( | ||
| oldViDefaultSc string | ||
| newViDefaultSc string | ||
| ) | ||
| if virtualImages, ok := oldMc.Spec.Settings["virtualImages"].(map[string]interface{}); ok { | ||
|
Contributor
There was a problem hiding this comment. Use consts, not string literals |
||
| if defaultClass, ok := virtualImages["defaultStorageClassName"].(string); ok { | ||
| oldViDefaultSc = defaultClass | ||
| } | ||
| } | ||
| if virtualImages, ok := newMc.Spec.Settings["virtualImages"].(map[string]interface{}); ok { | ||
| if defaultClass, ok := virtualImages["defaultStorageClassName"].(string); ok { | ||
| oldViDefaultSc = defaultClass | ||
| } | ||
| } | ||
| return oldViDefaultSc != newViDefaultSc | ||
| }, | ||
| }, | ||
| ) | ||
| } | ||
|
|
||
| func (w ModuleConfigWatcher) enqueueRequests(ctx context.Context, object client.Object) []reconcile.Request { | ||
| var vis virtv2.VirtualImageList | ||
| err := w.client.List(ctx, &vis, &client.ListOptions{ | ||
| FieldSelector: fields.OneTermEqualSelector(indexer.IndexFieldVIByNotReadyStorageClass, string(vicondition.StorageClassReadyType)), | ||
| }) | ||
| if err != nil { | ||
| w.logger.Error(fmt.Sprintf("failed to list virtual images: %s", err)) | ||
| return []reconcile.Request{} | ||
| } | ||
|
|
||
| var requests []reconcile.Request | ||
| for _, vi := range vis.Items { | ||
| requests = append(requests, reconcile.Request{ | ||
| NamespacedName: types.NamespacedName{ | ||
| Name: vi.Name, | ||
| Namespace: vi.Namespace, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| return requests | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why with this name you indexing by sc ready? And ignore non pvc VI please.